Re: [-mm][PATCH 4/4] Add memrlimit controller accounting and control (v4)
- From: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
- Date: Thu, 15 May 2008 01:09:46 +0530
* Pavel Emelyanov <xemul@xxxxxxxxxx> [2008-05-14 17:32:42]:
AFAIS you didn't cover all the cases when VM expands. At least all
the arch/ia64/ia32/binfmt_elf32.c is missed.
I'd insert this charge into insert_vm_struct. This would a) cover
all of the missed cases and b) reduce the amount of places to patch.
I thought I have those covered. insert_vm_struct() is called from
places that we have covered in this patch. As far as
arch/ia64/ia32/binfmt_elf32.c is concerned, it inserts a GDT, LDT
and does not change total_vm. Having said that, I am not against
putting the hooks in insert_vm_struct().
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [-mm][PATCH 0/4] Add memrlimit controller (v4)
- From: Balbir Singh
- [-mm][PATCH 4/4] Add memrlimit controller accounting and control (v4)
- From: Balbir Singh
- Re: [-mm][PATCH 4/4] Add memrlimit controller accounting and control (v4)
- From: Pavel Emelyanov
- [-mm][PATCH 0/4] Add memrlimit controller (v4)
- Prev by Date: Re: [GIT PATCHES] V4L/DVB fixes for 2.6.26
- Next by Date: Re: [announce] "kill the Big Kernel Lock (BKL)" tree
- Previous by thread: Re: [-mm][PATCH 4/4] Add memrlimit controller accounting and control (v4)
- Next by thread: 2.6.26-rc1 sound regression
- Index(es):
Relevant Pages
|