Re: [-mm][PATCH 4/4] Add memrlimit controller accounting and control (v4)



* Pavel Emelyanov <xemul@xxxxxxxxxx> [2008-05-14 17:32:42]:


AFAIS you didn't cover all the cases when VM expands. At least all
the arch/ia64/ia32/binfmt_elf32.c is missed.

I'd insert this charge into insert_vm_struct. This would a) cover
all of the missed cases and b) reduce the amount of places to patch.


I thought I have those covered. insert_vm_struct() is called from
places that we have covered in this patch. As far as
arch/ia64/ia32/binfmt_elf32.c is concerned, it inserts a GDT, LDT
and does not change total_vm. Having said that, I am not against
putting the hooks in insert_vm_struct().


--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [PATCH 7/12] memcg add function to move account
    ... This patch provides a function to move account information of a page between ... This moving of page_cgroup is done under ... * this moving of charge never fails. ...
    (Linux-Kernel)
  • [patch 1/2] memcg: hierarchy, yet another one.
    ... I'm just wondering how to support hirerachy and not indend to improve this now. ... This patch adds following interface to res_counter. ... By this, if res_counter is properly intialized, a charge to res_counter ... charge - try to consume more resource. ...
    (Linux-Kernel)
  • [RFC][PATCH -mm 4/7] memcg: lockless page_cgroup
    ... page_cgroup is guarded by RCU. ... we have to confirm there is no race. ... There will be race because charge is done before lock_page. ... This patch moves mem_cgroup_chargeunder lock_page. ...
    (Linux-Kernel)
  • [mmotm][PATCH] coalescing uncharge
    ... After this patch, lock conention in uncharge is reduced. ... This patch is a trial for reducing lock contention. ... charge is done one by one via demand-paging. ...
    (Linux-Kernel)
  • Re: Coulombs constant is a CGS kludge
    ... A little analysis using mks units can ... >which is simply charge Q spread over any size spherical area. ... >Coulomb's constant is a patch used to purify the mongrel charge Q'. ... theory of Dual Space. ...
    (sci.physics.relativity)