Re: [PATCH] au1000_eth: remove useless check
- From: Jeff Garzik <jgarzik@xxxxxxxxx>
- Date: Thu, 22 May 2008 06:22:22 -0400
Francois Romieu wrote:
The lifespan of the device covers the request_irq .. free_irq interval.
The cast of a void * pointer is not needed either.
Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index 3634b5f..7023d77 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -1239,12 +1239,7 @@ static int au1000_rx(struct net_device *dev)
*/
static irqreturn_t au1000_interrupt(int irq, void *dev_id)
{
- struct net_device *dev = (struct net_device *) dev_id;
-
- if (dev == NULL) {
- printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
- return IRQ_RETVAL(1);
- }
+ struct net_device *dev = dev_id;
applied
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 3/6] drivers/net: remove null pointer dereference
- From: Julia Lawall
- Re: [PATCH 3/6] drivers/net: remove null pointer dereference
- From: Francois Romieu
- Re: [PATCH 3/6] drivers/net: remove null pointer dereference
- From: Julia Lawall
- [PATCH] au1000_eth: remove useless check
- From: Francois Romieu
- [PATCH 3/6] drivers/net: remove null pointer dereference
- Prev by Date: Re: [PATCH 1/1] Blackfin EMAC Driver: Removed duplicated include <linux/ethtool.h> in drivers/net/bfin_mac.c.
- Next by Date: Re: [BUG] linux-next: Tree for May 19/20/21 - BUG at arch/x86/kernel/io_apic_64.c:353!
- Previous by thread: [PATCH] au1000_eth: remove useless check
- Next by thread: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference
- Index(es):
Relevant Pages
|
