Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver



Hi Grant,

+ - compatible : should be "linux,mmc-spi".
+ - linux,modalias - should be "of_mmc_spi".

I'm not even sure if the whole linux,modalias is even a good idea. I
had kind of thrown it in there as a convenient way to override
compatible when needed, but I haven't really thought it out very well
and I think it is rather a hack.

The real problem is we don't yet have good method (or place) to apply
a translation table from compatible values to modaliases. Ideally,
the translations should be part of the drivers themselves, but that
causes a chicken and egg problem of needing to load the driver to get
access to the table to know if it is the correct driver... Of course,
I'm really not very familiar with the whole module autoloading
mechanism. Regardless; binding should be based on compatible, not on
a hacky and bogus linux,modalias property.

i2c exactly has the same problem. Here the compatible entry is used
in drivers/of/of_i2c.c and mangled into a name to be used as modalias.
It's still sort of hackish, but it seems to be a compromise acceptable
by both OF and i2c folks.

Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH 2/2] platform: Facilitate the creation of pseudo-platform buses
    ... Since we seem to be in agreement now that the a new bus may not the ... bus types, keep the platform_bus as is, but simply override the few ... changes to the driver model. ... I'm not opposed to modifying the platform_bus_type to support the use-case. ...
    (Linux-Kernel)
  • Shared Memory Between The Driver and The Device
    ... It puts its registers to the PCI Bus ... at the begining so that the driver gets them. ... buffers and does it so. ... about the translation. ...
    (microsoft.public.windowsce.platbuilder)
  • Re: where did my 2nd screen go?
    ... Modaliases for the NVIDIA binary X.Org drive ... NVIDIA binary Xorg driver ... The reason I find it odd is because when I was installing the 190 ... Which of the above nvidia packages can I remove with dpkg -r ??? ...
    (Ubuntu)
  • Re: Cover Up: Unexplained accelerator deaths in American brand cars make Toyota deaths look insigni
    ... under the floor mat recall last month. ... "A CHP officer pulled up alongside Sikes and was able to help the driver eventually slow to 50 mph before shifting into neutral, which Toyota says you can do by holding the gear shift in "N" for 2 seconds. ... so now that's two seconds to override the computer controlled transmission PLUS three seconds to override the computer controlled engine, bringing the cumulative total time the driver would have to spend overriding computer controlled components up to FIVE SECONDS.) ...
    (rec.autos.driving)
  • Re: Mutual Exclusion for shared Buffer b/n User and Kernel
    ... the translation had to occur in user mode. ... so that MSDN documentation assumes that the caller is a driver. ... probably from Middle Low German mAt; ... English gemetta guest at one's table, mete food -- more at MEAT ...
    (microsoft.public.win32.programmer.kernel)