[PATCH] firewire: don't panic on invalid AR request buffer
- From: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
- Date: Sat, 31 May 2008 19:01:26 +0200 (CEST)
BUG() at this place is wrong. (Unless if the low level driver would
already do higher-level input validation of incoming request headers.)
Invalid incoming requests or bugs in the controller which corrupt the
AR-req buffer needlessly crashed the box because this is run in tasklet
context.
Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
---
drivers/firewire/fw-transaction.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/drivers/firewire/fw-transaction.c
===================================================================
--- linux.orig/drivers/firewire/fw-transaction.c
+++ linux/drivers/firewire/fw-transaction.c
@@ -575,7 +575,8 @@ allocate_request(struct fw_packet *p)
break;
default:
- BUG();
+ fw_error("ERROR - corrupt request received - %08x %08x %08x\n",
+ p->header[0], p->header[1], p->header[2]);
return NULL;
}
--
Stefan Richter
-=====-==--- -=-= =====
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Prev by Date: Re: Wireless-testing's b43 panics in b43_generate_txhdr on packet transmit
- Next by Date: Re: Wireless-testing's b43 panics in b43_generate_txhdr on packet transmit
- Previous by thread: [PATCH] coredump: zap_threads: comments && use while_each_thread()
- Next by thread: [PATCH] firewire: fw-ohci: use of uninitialized data in AR handler
- Index(es):
Relevant Pages
|
