[GIT PULL] fix kbuild regression
- From: Sam Ravnborg <sam@xxxxxxxxxxxx>
- Date: Sat, 31 May 2008 22:37:51 +0200
Hi Linus.
Please pull from:
ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fixes.git
Sam
To get the following fix:
Sam Ravnborg (1):
kbuild: fix $(src) assignmnet with external modules
When we introduced support for KBUILD_EXTRA_SYMBOLS
we started to include the externam module's kbuild
file when doing the final modpost step.
As external modules often do:
ccflags-y := -I$(src)
We had problems because $(src) was unassinged and
gcc then used the next parameter for -I resulting in
strange build failures.
Fix is to assign $(src) and $(obj) when building
external modules.
This fixes: http://bugzilla.kernel.org/show_bug.cgi?id=10798
Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Tvrtko <tvrtko.ursulin@xxxxxxxxxx>
Cc: Andrea Arcangeli <andrea@xxxxxxxxxxxx>
Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>
scripts/Makefile.modpost | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index a098a04..17092d6 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -43,7 +43,13 @@ _modpost: __modpost
include include/config/auto.conf
include scripts/Kbuild.include
+# When building external modules load the Kbuild file to retreive EXTRA_SYMBOLS info
ifneq ($(KBUILD_EXTMOD),)
+
+# set src + obj - they may be used when building the .mod.c file
+obj := $(KBUILD_EXTMOD)
+src := $(obj)
+
# Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS
include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \
$(KBUILD_EXTMOD)/Kbuild, $(KBUILD_EXTMOD)/Makefile)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Prev by Date: Re: Wireless-testing's b43 panics in b43_generate_txhdr on packet transmit
- Next by Date: Re: [Bug #10816] vt/fbcon: fix background color on line feed
- Previous by thread: sh64 build error - sh, kbuild or binutils problem?
- Next by thread: [PATCH] cputopology: Add default CPU topology information [3rd try]
- Index(es):
Relevant Pages
|
