Re: [PATCH 08/39] don't use word-size specifiers

From: "H. Peter Anvin" <hpa@xxxxxxxxxx>
Date: Fri, 27 Jun 2008 16:22:30 -0700

H. Peter Anvin wrote:

I hate to say it, but I really think this is a step backwards in readability. Consistency is a good thing, and with the suffixes in place we are consistent between instructions that refer to memory and instructions that refer to registers. We also get one more check on things, where the assembler can tell the programmer he probably typoed.

So I would prefer if we *didn't* go down this route, except for explicit unification, but that's not the case here (since the size is still explicit in the register names.)

Okay, I didn't really explain what I meant very well here...

Obviously, most of your patch series is all about unification, and that is a Good Thing, and thank you for doing it. What I was trying to say was that it is not obvious from just reading the patchset what changes are necessary for unification, and which one are a stylistic change. If *all* the changes are unification, please just say so and disregard this remark, and I'll go ahead and apply your patchset.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 08/39] don't use word-size specifiers
  - From: Glauber Costa

References:
- [PATCH 0/39] Merge files at x86/lib
  - From: Glauber Costa
- [PATCH 01/39] Don't use size specifiers
  - From: Glauber Costa
- [PATCH 02/39] provide delay loop for x86_64
  - From: Glauber Costa
- [PATCH 03/39] use rdtscll in read_current_timer for i386.
  - From: Glauber Costa
- [PATCH 04/39] explicitly use edx in const delay function.
  - From: Glauber Costa
- [PATCH 05/39] integrate delay functions
  - From: Glauber Costa
- [PATCH 06/39] use something common for both architectures
  - From: Glauber Costa
- [PATCH 07/39] don't clobber r8 nor use rcx
  - From: Glauber Costa
- [PATCH 08/39] don't use word-size specifiers
  - From: Glauber Costa
- Re: [PATCH 08/39] don't use word-size specifiers
  - From: H. Peter Anvin

Prev by Date: Re: [PATCH 08/39] don't use word-size specifiers
Next by Date: Re: [PATCH 001/001] linux-input: Support for BCM5974 multitouch trackpad
Previous by thread: Re: [PATCH 08/39] don't use word-size specifiers
Next by thread: Re: [PATCH 08/39] don't use word-size specifiers
Index(es):
- Date
- Thread

Relevant Pages

Re: [PATCH 08/39] dont use word-size specifiers
... and with the suffixes in place we are consistent between instructions that refer to memory and instructions that refer to registers. ... So I would prefer if we *didn't* go down this route, except for explicit unification, but that's not the case here ... Obviously, most of your patch series is all about unification, and that is a Good Thing, and thank you for doing it. ...
(Linux-Kernel)
Re: ActiveSync Cant Seem to Find Outlook
... > refer to the instructions in the following MSKB and make sure Collaboration ...
(microsoft.public.pocketpc.activesync)
Re: Word spell check failure
... Thanks for the sympathy. ... The style infection you refer to would explain ... instructions in the style descriptions. ...
(microsoft.public.mac.office.word)
Re: NTDS ISAM and NTDS SDPROP errors
... For instructions on how to perform the defrag of the DIT, refer to kb232122. ...
(microsoft.public.windows.server.active_directory)
RE: add data t drop down list use a different worksheet same workbook
... you can refer to it in data validation on a different ... sheet. ... There are instructions here: ...
(microsoft.public.excel.worksheet.functions)