[PATCH 24/24] kconfig: make defconfig is no longer chatty

make defconfig generated a lot of output
then noone actually read.
Use conf_set_all_new_symbols() to generate the default
configuration and avoid the chatty output.

A typical run now looks like this:
$ make defconfig
*** Default configuration is based on 'i386_defconfig'
arch/x86/configs/i386_defconfig:13:warning: trying to assign nonexistent symbol SEMAPHORE_SLEEPERS
arch/x86/configs/i386_defconfig:176:warning: trying to assign nonexistent symbol PREEMPT_BKL
...
arch/x86/configs/i386_defconfig:1386:warning: trying to assign nonexistent symbol INSTRUMENTATION
$

As an added benefit we now clearly see the warnings generated
in the start of the process.

Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Roman Zippel <zippel@xxxxxxxxxxxxxx>
---
scripts/kconfig/conf.c | 11 +++--------
1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 6cdaa0c..9fba838 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -102,9 +102,6 @@ static int conf_askvalue(struct symbol *sym, const char *def)
fflush(stdout);
fgets(line, 128, stdin);
return 1;
- case set_default:
- printf("%s\n", def);
- return 1;
default:
break;
}
@@ -318,10 +315,6 @@ static int conf_choice(struct menu *menu)
else
continue;
break;
- case set_default:
- cnt = def;
- printf("%d\n", cnt);
- break;
default:
break;
}
@@ -589,13 +582,15 @@ int main(int ac, char **av)
case set_random:
conf_set_all_new_symbols(def_random);
break;
+ case set_default:
+ conf_set_all_new_symbols(def_default);
+ break;
case ask_silent:
case ask_new:
if (conf_silent_update())
exit(1);
break;
case ask_all:
- case set_default:
if (conf_update())
exit(1);
break;
--
1.5.6.1.93.gef98

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [2.6 patch] defconfigs shouldnt set CONFIG_BROKEN=y
    ... > are shipped with since they aren't updated every time some configuration ... > in this defconfig gets for some reason marked as broken in the Kconfig ... If, in order to have a working platform configuration, they deem that ... I request that either you leave the ARM platform configurations ...
    (Linux-Kernel)
  • Re: [2.6 patch] defconfigs shouldnt set CONFIG_BROKEN=y
    ... of running one of the various configuration targets; ... If you run the defconfig target, it will copy the config file and run oldconfig, thus resulting in a different configuration file than what was in the defconfig, and thus people may come to the wrong conclusion that if a driver is enabled in a defconfig file, it will be built. ... Simon ...
    (Linux-Kernel)
  • Re: [2.6 patch] defconfigs shouldnt set CONFIG_BROKEN=y
    ... > Adrian Bunk wrote: ... A defconfig file should be the result ... thus resulting in a different configuration file ... > a driver is enabled in a defconfig file, ...
    (Linux-Kernel)
  • Re: [PATCH] default to n for GROUP_SCHED and FAIR_GROUP_SCHED
    ... Let me try (on my i386 box so I use x86_&4 so I know oldconfig will ask): ... $ make defconfig ARCH=x86_64 ... Run 'make oldconfig' to update configuration. ...
    (Linux-Kernel)
  • Re: 2.6.22.7 default kernel configuration
    ... Can please someone let me know what is criteria for default kernel ... By default configuration size of vmlinux is 41 MB and it includes ... There is nu deeper thoughts behind the i386 defconfig. ... Other architectures try to let their defconfig cover a lot ...
    (Linux-Kernel)