Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"



On Fri, 2008-07-04 at 09:15 -0400, Jeff Garzik wrote:

However, there is still a broken element to the system: the firmware no
longer rides along in the module's .ko file. That introduces new
problems for any user and script that copies modules around.

The compiled-in firmware should be in the same place where it was before
your changes -- in the driver's kernel module.

No, Jeff. That is neither new, nor a real problem. You're just
posturing.

That's the way it has been for a _long_ time anyway, for any modern
driver which uses request_firmware(). The whole point about modules is
_modularity_. Yes, that means that sometimes they depend on _other_
modules, or on firmware.

The scripts which handle that kind of thing have handled inter-module
dependencies, and MODULE_FIRMWARE(), for a long time now.

If I ask mkinitrd to include the b43 driver in my initrd, for example,
it should quite happily include both mac80211.ko and the required
firmware.

All I'm doing is updating some of the older drivers which don't conform
to current best practice, and which still keep large chunks of data in
unswappable kernel memory instead of loading it on demand. And making
that more workable in the general case, but giving the _option_ of
building arbitrary firmware into the kernel, for _all_ modern drivers.

Your argument makes about as much sense as an argument that we should
link b43.ko with mac80211.ko so that the 802.11 core code "rides along
in the module's .ko file". It's just silly.

--
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: Linux GPL and binary module exception clause?
    ... >> But also note how it's only the BINARY MODULE that is a derived work. ... > a device driver containing a binary blob that was explicitly written as ... Clearly it no longer depends on the kernel, and you can show that to ... And I think this argument is _especially_ strong for things like firmware ...
    (Linux-Kernel)
  • Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
    ... the kernel handles device nodes and on how udev maps them to real ... Please keep in mind that when we created request_firmwaremost of the driver model developers still thought that having class devices was a good idea. ... That has changed and to represent firmware loading in a clean and race free environment where you could load multipl firmwares at the same time for the same driver, ... firmware files inside the kernel. ...
    (Linux-Kernel)
  • Re: [PATCH] request_firmware: skip timeout if userspace was not notified
    ... needs to be removed from the kernel, that's known for a very long ... your point is that the firmware loader is ... or use a kernel module for the driver that needs ... kernel on boot if built in unless an initramfs is carefully ...
    (Linux-Kernel)
  • Re: ipw2200 and wpa_supplicant
    ... > theres a wpa fix in the latest kernel prepatch ... > and there was also a small patch in the thread on sf.net i posted the ... the new ipw2200 driver. ... Back old ipw2200 firmware files, ...
    (Fedora)
  • [PATCH 00/04] Load keyspan firmware with hotplug
    ... > That people didn't like the inclusion of firmware, ... - make the keyspan driver use request_firmware. ... - converter program used to dump the keyspan headers as IHex files. ... Open Source operating system kernel'. ...
    (Linux-Kernel)