request_firmware vs. resume (was Re: [PATCH] bnx2 - use request_firmware())

Hi!

The firmware needs to be reloaded every time the chip resets.
You're not saving anything/

See above, you aren't saving anything. The firmware needs to stay
around so it can be reloaded into the card during exceptions.

That is, unless you want a more failure prone system.

Ok so if tg3 always needs the same firmware and always needs it in memory
then maybe it isn't a significant candidate for request_firmware beyond
the neatness of distribution. I note the firmware hasn't changed in years
so it can easily be shipped separately and the one package would have
done for all this time.

It isn't just tg3. All the broadcom gigabit chips need this
kind of handling.

Basically all of the drivers we are pushing back on.

I bet there are other similar examples.

Be careful about request_firmware. Doing it right w.r.t.
suspend/resume is quite tricky: you have to load it from userspace
before kernel starts, so that you can use it during resume...

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: request_firmware vs. resume (was Re: [PATCH] bnx2 - use request_firmware())
    ... around so it can be reloaded into the card during exceptions. ... Ok so if tg3 always needs the same firmware and always needs it in memory ... It isn't just tg3. ... you have to cache it in memory before your ->suspendis invoked. ...
    (Linux-Kernel)
  • Re: [PATCH] bnx2 - use request_firmware()
    ... around so it can be reloaded into the card during exceptions. ... unless you want a more failure prone system. ... Ok so if tg3 always needs the same firmware and always needs it in memory ... the neatness of distribution. ...
    (Linux-Kernel)
  • Some questions about handling exceptions and when to throw them
    ... still confused as to just what the best practices are for using exceptions. ... In the event that a customer can't be ... "FirmwareService" and it is responsible for adding new versions of firmware ... This function is similiar to GetEmployeeDefaultPrinter() in that it makes a ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: Some questions about handling exceptions and when to throw them
    ... you should not be using exceptions for Logic in your code. ... finding a customer is by no means an illegal use of a class. ... This function is similiar to GetEmployeeDefaultPrinter() in that it makes ... // Presenter method to get a customer's firmware path and display in the ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
    ... firmware: requesting tigon/tg3_tso.bin ... else broke tg3 in -mm... ... for a few minutes in earlyish boot with a message about tg3_tso.bin, ...
    (Linux-Kernel)