Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Fri, 11 Jul 2008 09:46:03 +0200
* Milton Miller <miltonm@xxxxxxx> wrote:
Hi Rusty, Ingo.
Rusty's patch [PATCH 3/3] stop_machine: use cpu mask rather than magic
numbers didn't find kernel/trace/ftrace.c in -next, causing an
immediate almost NULL pointer dereference in ftrace_dynamic_init.
Rusty - what's going on here? Please do not change APIs like that, which
cause code to crash. Either do a compatible API change, or change it
over in a way that causes clear build failures, not crashes.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
- From: Rusty Russell
- Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
- From: Ingo Molnar
- Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
- References:
- [PATCH 2/3] stop_machine: simplify
- From: Rusty Russell
- [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
- From: Milton Miller
- [PATCH 2/3] stop_machine: simplify
- Prev by Date: [XFS REGRESSION, PATCH] Fix reference counting race on log buffers
- Next by Date: Re: [PATCH] ftrace: Documentation
- Previous by thread: Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
- Next by thread: Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
- Index(es):
Relevant Pages
|
