Re: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
- Date: Fri, 11 Jul 2008 12:18:42 -0700
On Tue, 8 Jul 2008 23:02:01 -0400 Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote:
* Masami Hiramatsu (mhiramat@xxxxxxxxxx) wrote:
Introduce marker_entry_free_old() and check old pointer is NULL before
setting call_rcu_sched(), because marker_entry_remove/add_probe() can
return NULL.
Hi Masami,
I doubt this is a bug per se, because kfree accepts NULL pointers (and
kfree is the only action done on the oldptr by free_old_closure).
This cleans up the code, so I think it's good to merge your patch, but I
would definitely not classify this as a bugfix.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
I cannot get this to apply on the rather dated tree which I have on this
rather not-on-the-internet machine. Please merge this patch locally, test,
rewrite the changelog and resend it to someone ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- From: Mathieu Desnoyers
- Re: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- References:
- [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- From: Masami Hiramatsu
- Re: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- From: Mathieu Desnoyers
- [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- Prev by Date: Re: [PATCH] reiserfs: discard prealloc in reiserfs_delete_inode
- Next by Date: Re: [PATCH] init/version.c: Silenced sparse warning by declaring the version string.
- Previous by thread: Re: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- Next by thread: Re: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
- Index(es):
Relevant Pages
|
