[PATCH 1/9] sched: test below 0 on unsigned sysctl_sched_rt_period
- From: roel kluin <roel.kluin@xxxxxxxxx>
- Date: Mon, 21 Jul 2008 20:28:34 -0400
Peter, you added the test in global_rt_runtime(), in commit
d0b27fa77854b149ad4af08b0fe47fe712a47ade
could you take a look at it and tell whether this test should
be replaced by something else?
The patch was only checkpatch tested
---
sysctl_sched_rt_period is unsigned so the test doesn't work.
state_filter is an unsigned long so the test didn't work
Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
---
diff --git a/kernel/sched.c b/kernel/sched.c
index 99e6d85..2030340 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -832,9 +832,6 @@ static inline u64 global_rt_period(void)
static inline u64 global_rt_runtime(void)
{
- if (sysctl_sched_rt_period < 0)
- return RUNTIME_INF;
-
return (u64)sysctl_sched_rt_runtime * NSEC_PER_USEC;
}
@@ -5707,7 +5704,7 @@ void show_state_filter(unsigned long state_filter)
/*
* Only show locks if all tasks are dumped:
*/
- if (state_filter == -1)
+ if (state_filter == -1ul)
debug_show_all_locks();
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 1/9] sched: test below 0 on unsigned sysctl_sched_rt_period
- From: Peter Zijlstra
- Re: [PATCH 1/9] sched: test below 0 on unsigned sysctl_sched_rt_period
- Prev by Date: Re: request for comment: generic kernel interface for malware vendors
- Next by Date: [PATCH 2/9] sis fb: test below 0 on unsigned type_no
- Previous by thread: [PATCH] serial: fix struct uart_info change fallout
- Next by thread: Re: [PATCH 1/9] sched: test below 0 on unsigned sysctl_sched_rt_period
- Index(es):
Relevant Pages
|
