Re: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test
- From: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
- Date: Fri, 25 Jul 2008 00:35:26 +0900 (JST)
On Thu, 17 Jul 2008 21:16:36 +0200, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
if (initrd_start && !initrd_below_start_ok &&
- initrd_start < min_low_pfn << PAGE_SHIFT) {
+ page_to_pfn(virt_to_page(initrd_start)) < min_low_pfn) {
printk(KERN_CRIT "initrd overwritten (0x%08lx < 0x%08lx) - "
- "disabling it.\n",initrd_start,min_low_pfn << PAGE_SHIFT);
+ "disabling it.\n",
+ page_to_pfn(virt_to_page(initrd_start)), min_low_pfn);
initrd_start = 0;
}
This patch causes warnings on mips:
linux/init/main.c: In function 'start_kernel':
linux/init/main.c:633: warning: passing argument 1 of 'virt_to_phys' makes pointer from integer without a cast
linux/init/main.c:636: warning: passing argument 1 of 'virt_to_phys' makes pointer from integer without a cast
Because an argument of mips virt_to_phys() is an pointer and
initrd_start is unsigned long. It seems most (all?) arch's
virt_to_phys() casts its argument to unsigned long internally. Should
mips follow?
---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test
- From: Geert Uytterhoeven
- Re: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test
- References:
- [patch 00/29] m68k patches for 2.6.27
- From: Geert Uytterhoeven
- [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test
- From: Geert Uytterhoeven
- [patch 00/29] m68k patches for 2.6.27
- Prev by Date: [ANNOUNCE] ACPI BIOS Guideline for Linux
- Next by Date: Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
- Previous by thread: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test
- Next by thread: Re: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test
- Index(es):
Relevant Pages
|
