Re: [PATCH] nwflash: fix build errors and warning

On Sun, Jul 27, 2008 at 12:02:20AM +0900, Akinobu Mita wrote:
On Sat, Jul 26, 2008 at 03:18:08PM +0100, Russell King - ARM Linux wrote:
On Fri, Jul 25, 2008 at 01:48:18AM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
From: Akinobu Mita <akinobu.mita@xxxxxxxxx>

Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
Cc: Tim Schmielau <tim@xxxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Argh... Are people now submitting untested patches as a rule?

drivers/char/nwflash.c: In function 'flash_read':
drivers/char/nwflash.c:129: error: 'p' undeclared (first use in this function)
drivers/char/nwflash.c:129: error: (Each undeclared identifier is reported only once
drivers/char/nwflash.c:129: error: for each function it appears in.)
drivers/char/nwflash.c:129: error: 'count' undeclared (first use in this function)
drivers/char/nwflash.c:136: warning: passing argument 4 of 'simple_read_from_buffer' discards qualifiers from pointer target type
make[2]: *** [drivers/char/nwflash.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

Sorry. I'm preparing cross compiler. But this patch should fix this
problem.

I sort of did the same - but merely changing the names of the variables
generates other warnings. More complete (and build-tested) commit
queued up:

http://ftp.arm.linux.org.uk/git/gitweb.cgi?p=linux-2.6-arm.git;a=commitdiff;h=4ef584ba84125b67c17b5aded38e7783cd8cdef0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: ATA Issues VIA 8251
    ... isn't some sort of a patch to fix this? ... Submitting a full PR is usually a more effective way to get someone, ...
    (comp.unix.bsd.freebsd.misc)
  • Re: pcmcia_ioctl.c compile error
    ... to sort the resulting mess out, given that I was not even able to be ... A subset of that patch had also already been discussed between Philipp, ... The fix was already known... ... sort it until Thursday. ...
    (Linux-Kernel)
  • Re: Memory Error - WMM Closes automatically
    ... something so unstable without issuing some sort of fix or patch! ... Movie Maker 2 Crashes and Hangs ...
    (microsoft.public.windowsxp.moviemaker)
  • Re: [PATCH] MAINTAINERS: Sort ordering
    ... also sort the U/V confusion... ... I'll send a further patch to fix that at some point - well spotted. ...
    (Linux-Kernel)
  • [PATCH] nwflash: fix build errors and warning
    ... I'm preparing cross compiler. ... But this patch should fix this ... Subject: nwflash: fix build errors and warning ...
    (Linux-Kernel)