Re: [PATCH] Removes extra checking in kernel/cpuset.c
- From: James Kosin <jkosin@xxxxxxxxxxxxxxxxxx>
- Date: Thu, 31 Jul 2008 14:16:20 -0400
Rakib Mullick wrote:
Hello guys, this patch removes an extra checking over 'cs' in
functions 'guarantee_online_cpus' and 'guarantee_online_mems'.
Thanks.
Signed-off-by: Md.Rakib H. Mullick (rakib.mullick@xxxxxxxxx)
I'd have to NAK this one as well. 2-reasons:
1) Your patch is guaranteed to generate a NULL pointer dereference at some point. You keep using cs; and assigning cs = cs->parent in the loop, at some point you may end up at the TOP of the tree where cs->parent == NULL.
2) The change breaks the actual meaning of the code. Which is suggesting my the short snippet, find an entry (while loop)... if the entry is found (if cs test), do this otherwise BUG out. Your code is saying, if cs is not NULL initially... find someplace then do something. The function never BUGS out unless someone calls with cs NULL initially.
James Kosin
Attachment:
signature.asc
Description: OpenPGP digital signature
- Prev by Date: Re: suspend to ram regression in current GIT, bisected
- Next by Date: Re: linux-next: Tree for July 30
- Previous by thread: Re: [PATCH] Removes extra checking in kernel/cpuset.c
- Next by thread: [stable] last-minute patch for 2.6.25-stable
- Index(es):
Relevant Pages
|
