Re: [PATCH 1/7] dynamic debug v2 - infrastructure

On Thu, Aug 14, 2008 at 07:53:48AM -0700, Greg KH wrote:
Also, would it make sense to add a patch like the one below to this
code? It might be nice to know when each module's debugging value is
manually changed by the user for the log files.

If you like it, I can merge it in the main patch.

thanks,

greg k-h

---
lib/dynamic_printk.c | 6 ++++++
1 file changed, 6 insertions(+)

--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -288,6 +288,9 @@ static ssize_t pr_debug_write(struct fil
num_enabled++;
dynamic_enabled = DYNAMIC_ENABLED_SOME;
err = 0;
+ printk(KERN_DEBUG
+ "debugging enabled for module %s",
+ elem->name);
} else if (!value && (elem->enable == 1)) {
elem->enable = 0;
num_enabled--;
@@ -304,6 +307,9 @@ static ssize_t pr_debug_write(struct fil
dynamic_enabled =
DYNAMIC_ENABLED_NONE;
err = 0;
+ printk(KERN_DEBUG
+ "debugging disabled for module "
+ "%s", elem->name);
}
}
}


looks good. we might also want to add a message for the cases where are the
modules are enabled/disabled too.

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [NFS] blocks of zeros (NULLs) in NFS files in kernels >= 2.6.20
    ... some of the writers are not in our control. ... job 1> out 2> err & ... we actually do like caching the writes (b/c log files do not need ...
    (Linux-Kernel)
  • Web Server Log Import fails giving HRESULT: -2147467259, Minor Code: 0, Source: , Description er
    ... data from Web server log files into Database which is on another ... Err: SQL Error: 0, Description: 22018 ... Storage detected errors on this connection with the SQL ... trying to import only 4 log files when I ran this trace. ...
    (microsoft.public.sqlserver.dts)
  • Only connects as guest round 2
    ... have log files. ... I still get the "Critical communications ... socket 990, err = 10054 ...
    (microsoft.public.pocketpc.activesync)
  • Mail flow problem
    ... FAQ a shot: ... First look for errors in your MTA log files. ... Before my recent reinstallation of Fedora Core 5, ... I am running the Mailman that comes with Fedora Core 5. ...
    (Fedora)
  • Re: i386-RHLinux box hacked. What next?
    ... Have a look at the FAQ in my sig ... ... > was hacked into so that I can plug the hole. ... Were you running ssh, telnet, wu-ftpd, php... ... Your log files are also possibly able to provide some clues as to when ...
    (comp.security.misc)
Loading