Re: [2.6.27-rc4] XFS i_lock vs i_iolock...

On Mon, 2008-08-25 at 13:55 +1000, Dave Chinner wrote:
On Mon, Aug 25, 2008 at 12:12:23PM +1000, Lachlan McIlroy wrote:
Dave Chinner wrote:
On Fri, Aug 22, 2008 at 10:12:59PM +0100, Daniel J Blueman wrote:
On 2.6.27-rc4 with various debug options enabled, lockdep claims lock
ordering issues with XFS [1] - easiest reproducer is just running
xfs_fsr. Mount options I was using were
'nobarrier,noatime,nodiratime'.

Thanks,
Daniel

--- [1]

=======================================================
[ INFO: possible circular locking dependency detected ]
2.6.27-rc4-224c #1
-------------------------------------------------------
xfs_fsr/5763 is trying to acquire lock:
(&(&ip->i_lock)->mr_lock/2){--..}, at: [<ffffffff803ad8fc>] xfs_ilock+0x8c/0xb0

but task is already holding lock:
(&(&ip->i_iolock)->mr_lock/3){--..}, at: [<ffffffff803ad915>]
xfs_ilock+0xa5/0xb0

False positive. We do:

xfs_lock_two_inodes(ip, tip, XFS_IOLOCK_EXCL | XFS_ILOCK_EXCL);

Why not just change the above line to two lines:
xfs_lock_two_inodes(ip, tip, XFS_IOLOCK_EXCL);
xfs_lock_two_inodes(ip, tip, XFS_ILOCK_EXCL);

Yeah, that'd work, but it implllies that we no longer allow
xfs_lock_two_inodes() to take both inode locks at once.

How can you take two locks in one go? It seems to me you always need to
take them one after another, and as soon as you do that, you have
ordering constraints.

Of course it could be that doesn't matter, because there is another
serializing lock, but that isn't clear from this context.

It
would need a comment blaming^Wexplaining why lockdep requires
us to do this, and then debug code in xfs_lock_two_inodes() to
catch this when someone makes this mistake again in the future.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [2.6.27-rc4] XFS i_lock vs i_iolock...
    ... ordering issues with XFS - easiest reproducer is just running ... Mount options I was using were ... possible circular locking dependency detected] ... xfs_fsr/5763 is trying to acquire lock: ...
    (Linux-Kernel)
  • [2.6.27-rc4] XFS i_lock vs i_iolock...
    ... On 2.6.27-rc4 with various debug options enabled, lockdep claims lock ... ordering issues with XFS - easiest reproducer is just running ... Mount options I was using were ... possible circular locking dependency detected] ...
    (Linux-Kernel)
  • [BUG] 2.6.26-rc8-git2 - powerpc - circular locking dependency detected with net/ehea
    ... circular locking dependency is detected, ... ip/2214 is trying to acquire lock: ... Starting iprupdate: Checking ipr microcode levels ... Starting NFS services: ...
    (Linux-Kernel)
  • Re: dio_get_page() lockdep complaints
    ... fio/9741 is trying to acquire lock: ... I tried fio with this job file and did not get the possible circular locking dependency detected ... It's interesting that lockdep learned the ranking from a reiserfs ...
    (Linux-Kernel)
  • Re: dio_get_page() lockdep complaints
    ... possible circular locking dependency detected] ... fio/9741 is trying to acquire lock: ... # fio job file snip below ... It's interesting that lockdep learned the ranking from a reiserfs ...
    (Linux-Kernel)