Re: [Bugme-new] [Bug 11446] New: Automate "to compile as module" strings

On Thu, 28 Aug 2008 09:24:42 -0700 (PDT)
bugme-daemon@xxxxxxxxxxxxxxxxxxx wrote:


http://bugzilla.kernel.org/show_bug.cgi?id=11446

Summary: Automate "to compile as module" strings
Product: Other
Version: 2.5
KernelVersion: 2.6.27
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: enhancement
Priority: P1
Component: Configuration
AssignedTo: zippel@xxxxxxxxxxxxxx
ReportedBy: kernel1@xxxxxxxxxxxxxxxx


I've spent quite a bit of time scanning through Kconfig files correcting
various textual errors. One thing that I've noticed is variations of "To
compile X as a module, choose M here. The module will be called Y" occur
extremely frequently. A quick grep of the current mainline actually reveals
~1192 instances of it. It seems very redundant to me to have everyone who adds
a module or feature copy and paste this text, when it could seemingly be
dynamically generated with ease.

Is there any reason we can't simply standardize on one string, and display it
for any component that has the module option available?

Good point :)

The Kconfig system doesn't presently know the name of the module,
but that could be added. eg:


config BMAC
tristate "BMAC (G3 ethernet) support"
depends on PPC_PMAC && PPC32
+ modulename bmac
select CRC32
help
Say Y for support of BMAC Ethernet interfaces. These are used on G3
computers.

- To compile this driver as a module, choose M here: the module
- will be called bmac.


Any sane organisation would look at the benefit of this, weigh that
against the massive amount of code churn and would then run away howling.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Why leave the error handling to the caller?
    ... I didn't even mention the fact that it didn't compile. ... If the intended behavior of the program is to simply output all the strings with no further processing there would never be any reason for storing them and whatever is in the error recovery part of the program would better be the *entire* program. ... I assume the purpose of allocating the strings in some structure to begin with is that there really is some further processing to be done before outputting them. ... That would make the error handling function output data that would be wrong. ...
    (comp.lang.c)
  • Re: csc (C# Compiler) bug
    ... > I seem to have found a bug in csc. ... Here is some source that does not compile properly: ... This does not happen with all strings ... Its not a bug, its actually correct. ...
    (microsoft.public.dotnet.languages.csharp)
  • 50 years of progress in the language
    ... almost every program would compile and run correctly using ... Smaller length alphabetic test onstant strings were treated as ... Conversion between integer variabless and equivalent digit strings ... the character array and the character string. ...
    (comp.lang.fortran)
  • Re: [SLE] Kernel Woes: Comments, Please!
    ... > the major/only noticable difference, but the difference has to be in pppd, maybe tcpip ... As to the configuration, I upgraded from 8.2 to 9.1, so most of the ... I see strings like this printed in the xterm console where I ... and 'wvdial-pipe' shows: ...
    (SuSE)
  • Re: Newbie question(s)...
    ... Your proposed algorithm needs to execute on a computing ... symbols in the tape alphabet. ... The configuration history depends on the ... non-repeating strings. ...
    (sci.crypt)
Loading