Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- From: "Vegard Nossum" <vegard.nossum@xxxxxxxxx>
- Date: Sun, 31 Aug 2008 19:53:32 +0200
On Sun, Aug 31, 2008 at 7:51 PM, Paul E. McKenney
<paulmck@xxxxxxxxxxxxxxxxxx> wrote:
@@ -751,6 +749,7 @@ int __cpu_disable(void)
remove_siblinginfo(cpu);
cpu_clear(cpu, cpu_online_map);
Here ^^^
fixup_irqs();
+ cpu_clear(cpu, cpu_online_map);
local_flush_tlb_all();
cpu_clear(cpu, cpu_callin_map);
return 0;
Hm. Maybe my eyes are going bad. But isn't that now clearing the cpu
both before and after calling fixup_irqs()?
I don't believe so... I removed the earlier one and added the later
one. Or is there another one hidden somewhere that I missed?
See marker above. It's not removed, is it?
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- From: Paul E. McKenney
- Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- References:
- [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- From: Paul E. McKenney
- Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- From: Vegard Nossum
- Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- From: Paul E. McKenney
- [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- Prev by Date: Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- Next by Date: Re: Linux 2.6.27-rc5: System boot regression caused by commit a2bd7274b47124d2fc4dfdb8c0591f545ba749dd
- Previous by thread: Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- Next by thread: Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
- Index(es):
Relevant Pages
|
