DVB Update [PATCH 22/31] fix broken backward compat for DVBFE_GET_PARAMS

From: Manu Abraham <abraham.manu@xxxxxxxxx>
Date: Fri, 05 Sep 2008 00:26:40 +0400

From a4d4b171211d0c71eda0f807506e905df2b9e4ef Mon Sep 17 00:00:00 2001

From: Manu Abraham <manu@xxxxxxxxxxx>
Date: Thu, 4 Sep 2008 14:24:28 +0200
Subject: [PATCH] DVB fix broken backward compatibility for DVBFE_GET_PARAMS

DVBFE_GET_PARAMS 's backward compatibily was broken due to a
wrong copy. Fix it.

Thanks to Marco Schluessler <marco@xxxxxxxxxxxxx> for pointing
out the bug.

From: Manu Abraham <abraham.manu@xxxxxxxxx>
Signed-off-by: Manu Abraham <manu@xxxxxxxxxxx>

diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 2b28bd1..24ae622 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -1816,7 +1816,7 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
memcpy(parg, &fepriv->fe_params, sizeof (struct dvbfe_params));
err = fe->ops.get_params(fe, (struct dvbfe_params *) parg);
} else if (fe->ops.get_frontend) {
- err = fe->ops.get_frontend(fe, (struct dvb_frontend_parameters*) parg);
+ err = fe->ops.get_frontend(fe, &fepriv->parameters);
if (!err) {
if (olddrv_to_newapi(fe, &fepriv->fe_params, &fepriv->parameters, fe->ops.info.type) == -EINVAL)
printk("%s: ERROR !!! Converting Old parameters --> New parameters\n", __func__);

Prev by Date: DVB Update [PATCH 21/31] do not toggle legacy mode within ioctls
Next by Date: DVB Update [PATCH 23/31] fix broken usage of get_frontend_algo
Previous by thread: DVB Update [PATCH 21/31] do not toggle legacy mode within ioctls
Next by thread: DVB Update [PATCH 23/31] fix broken usage of get_frontend_algo
Index(es):
- Date
- Thread

Relevant Pages

DVB Update [PATCH 16/31] multiproto tree
... [PATCH] DVB Fix backward compatibility ... Backward compatibility was broken in terms that it was all ... around non-legacy devices being selected for device control ... and hence drivers with the old callbacks never worked. ...
(Linux-Kernel)
DVB Update [PATCH 16/31] fix backward compat
... [PATCH] DVB Fix backward compatibility ... Backward compatibility was broken in terms that it was all ... around non-legacy devices being selected for device control ... and hence drivers with the old callbacks never worked. ...
(Linux-Kernel)
Re: [PATCH 15/17] block: kill end_request()
... On Sat, Mar 21 2009, Tejun Heo wrote: ... end_requesthas been kept around for backward compatibility; ... Unnecessary local variable res ... This patch isn't correct. ...
(Linux-Kernel)
[2.6 patch] remove the deprecated check_gcc
... This patch was already sent on: ... Prev by Date: ...
(Linux-Kernel)
DVB Update [PATCH 22/31] multiproto tree
... [PATCH] DVB fix broken backward compatibility for DVBFE_GET_PARAMS ... Thanks to Marco Schluessler for pointing ... out the bug. ...
(Linux-Kernel)