Re: [PATCH] atmel_serial: update the powersave handler to match serial core

Hi,



----- Messaggio originale -----
Da: Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx>
A: Michael Trimarchi <trimarchimichael@xxxxxxxx>
Cc: linux-serial@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Andrew Victor <linux@xxxxxxxxxxxx>; Anti Sullin <anti.sullin@xxxxxxxxxxxxxx>
Inviato: Venerdì 19 settembre 2008, 18:15:51
Oggetto: Re: [PATCH] atmel_serial: update the powersave handler to match serial core


I agree it would be useful. It would require changing the port mux
configuration from the driver though, and there's no standardized
interface for doing that. Maybe this is a good motivation to come up
with one?


I think that a driver can do the request to a the gpio layer (may can be implemented
by the gpio-lib ) and give it only the gpio. The "gpio-lib" can save and restore
the status of the gpio, and request the handler, passing the gpio-id as
a data. So when the handler fire, we can now which peripheral is
interested on the wake-up event.

Btw, I assume the first character you receive will be lost when you do
this, right?


Yes, I haven't done a lot of test to see how many chars are lost (sure one I think).
Depends on the time spent after

/* Wait for interrupt to wake us up */
mcr p15, 0, r0, c7, c0, 4

Haavard

Regards Michael


__________________________________________________
Do You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi
http://mail.yahoo.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages