Re: [PATCH 0/2] x86: split out dumpstack code from traps_xx.c




* Alexander van Heukelum <heukelum@xxxxxxxxxxx> wrote:

Hi Ingo,

I intend to keep looking for possibilities to bring traps_32.c and
traps_64.c closer to each-other. One trivial way (from my point of
view) is to split out code into separate files. These two patches
split out a large piece of code that has nothing to do with hardware
traps. Are you willing to take those two patches? Or are they to
intrusive?

they are not intrusive at all! The right way to do such things is to
keep them in reasonably small files.

Patches are against the current master branch of the tip tree. The
defconfigs compile fine and I ran some simple configs within qemu.

would be nice to bring dumpstack_32.c and dumpstack_64.c together as
well. While some of the details like IST stack logic (which dont exist
on 32-bit) are special, most of the glue, the iterators, the boot
parameters, and even the output should be unified some more.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [PATCH 0/2] x86: split out dumpstack code from traps_xx.c
    ... I intend to keep looking for possibilities to bring traps_32.c ... and traps_64.c closer to each-other. ... two patches split out a large piece of code that has nothing to ... qemu. ...
    (Linux-Kernel)
  • Re: [PATCH] make headers_install kbuild target.
    ... year's kernel summit? ... We should split public bits into entirely separate files. ... Now, I'm perfectly happy with patches which do that, if you can actually ... But even though I think it's premature, I still don't _mind_ moving ...
    (Linux-Kernel)
  • Re: The performance and behaviour of the anti-fragmentation related patches
    ... You will see that the zone-based kernel is getting success rates ... closer to 40% as one would expect although there is still something amiss. ... I think the videos show how the patches actually ... get as many available maximally contiguous regions as the list patch. ...
    (Linux-Kernel)
  • Re: new /dev/random
    ... > And for the record, no I haven't looked at his patches, and don't ... > intend to. ... He's explained his intent multiple times in various forms [email, lists, ... No requirement to "publicly dismiss" his work as a ...
    (sci.crypt)
  • Re: [PATCH v3 0/7] can: CAN network device driver interface and drivers
    ... we have more patches for various CAN controllers in the pipeline ... and I actually intend to ask for an account on kernel.org and a GIT ...
    (Linux-Kernel)