[RFC patch 1/3] signals: split do_tkill

Split out the code from do_tkill to make it reusable by the follow up
patch which implements sys_rt_tgsigqueueinfo

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
---
kernel/signal.c | 31 ++++++++++++++++++++-----------
1 file changed, 20 insertions(+), 11 deletions(-)

Index: linux-2.6-tip/kernel/signal.c
===================================================================
--- linux-2.6-tip.orig/kernel/signal.c
+++ linux-2.6-tip/kernel/signal.c
@@ -2212,24 +2212,20 @@ sys_kill(pid_t pid, int sig)
return kill_something_info(sig, &info, pid);
}

-static int do_tkill(pid_t tgid, pid_t pid, int sig)
+static int
+do_send_specific(pid_t tgid, pid_t pid, int sig, struct siginfo *info)
{
- int error;
- struct siginfo info;
struct task_struct *p;
unsigned long flags;
+ int error = -ESRCH;

- error = -ESRCH;
- info.si_signo = sig;
- info.si_errno = 0;
- info.si_code = SI_TKILL;
- info.si_pid = task_tgid_vnr(current);
- info.si_uid = current->uid;
+ info->si_pid = task_tgid_vnr(current);
+ info->si_uid = current->uid;

rcu_read_lock();
p = find_task_by_vpid(pid);
if (p && (tgid <= 0 || task_tgid_vnr(p) == tgid)) {
- error = check_kill_permission(sig, &info, p);
+ error = check_kill_permission(sig, info, p);
/*
* The null signal is a permissions and process existence
* probe. No signal is actually delivered.
@@ -2239,7 +2235,7 @@ static int do_tkill(pid_t tgid, pid_t pi
* signal is private anyway.
*/
if (!error && sig && lock_task_sighand(p, &flags)) {
- error = specific_send_sig_info(sig, &info, p);
+ error = specific_send_sig_info(sig, info, p);
unlock_task_sighand(p, &flags);
}
}
@@ -2248,6 +2244,19 @@ static int do_tkill(pid_t tgid, pid_t pi
return error;
}

+static int do_tkill(pid_t tgid, pid_t pid, int sig)
+{
+ struct siginfo info;
+
+ info.si_signo = sig;
+ info.si_errno = 0;
+ info.si_code = SI_TKILL;
+ info.si_pid = task_tgid_vnr(current);
+ info.si_uid = current->uid;
+
+ return do_send_specific(tgid, pid, sig, &info);
+}
+
/**
* sys_tgkill - send signal to one specific thread
* @tgid: the thread group ID of the thread


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • [patch 1/3] signals: split do_tkill
    ... patch which implements sys_rt_tgsigqueueinfo ... The null signal is a permissions and process existence ... probe. ... * signal is private anyway. ...
    (Linux-Kernel)
  • [patch 1/3] signals: split do_tkill
    ... patch which implements sys_rt_tgsigqueueinfo ... The null signal is a permissions and process existence ... probe. ... * signal is private anyway. ...
    (Linux-Kernel)
  • [RFC patch 1/3] signals: split do_tkill
    ... patch which implements sys_rt_tgsigqueueinfo ... The null signal is a permissions and process existence ... probe. ... * signal is private anyway. ...
    (Linux-Kernel)
  • Re: SourceFire RNA
    ... So the active probe actually did its job well. ... >>system that relied solely on this information for vulnerability management. ... > If the patch was properly applied, ... Also, if a host changes ...
    (Focus-IDS)
  • Re: [RFC] NUMA futex hashing
    ... Based on various discussions and feedbacks, I cooked a patch that implements ... the notion of private futexes (private to a process, ... futex: Add new PRIVATE futex primitives for performance improvements ... return ret; ...
    (Linux-Kernel)