Re: [PATCH] Give kjournald a IOPRIO_CLASS_RT io priority

On Thu, Oct 02, 2008 at 09:55:11AM +0200, Jens Axboe wrote:
On Thu, Oct 02 2008, Andi Kleen wrote:
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:

On Wed, 1 Oct 2008 20:00:34 -0700 Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

Subject: [PATCH] Give kjournald a IOPRIO_CLASS_RT io priority

You proposed this a while back and it didn't happen and I forget
why and the changelog doesn't mention any of that?

XFS tried this some time ago too.

I think the issue was that real user supplied RT applications don't want to
compete with a "pseudo RT" kjournald.

So it would really need a new priority class between RT and normal priority.

Good point. I think we should mark the IO as sync, and maintain the same
priority level. Any IO that ends up being waited on is sync by
definition, we just need to expand the coverage a bit.

That's what XFS has always done - mark the journal I/O as sync.
Still, once you load up the elevator, the sync I/O can still get
delayed for hundreds of milliseconds before dispatch, which was
why I started looking at boosting the priority of the log I/O.
It proved to be much more effective at getting the log I/O
dispatched than the existing "mark it sync" technique....

The RT folk were happy with the idea of journal I/O using the
highest non-RT priority for the journal, but I never got around
to testing that out as I had a bunnch of other stuff to fix at
the time.

Cheers,

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH] Give kjournald a IOPRIO_CLASS_RT io priority
    ... That's what XFS has always done - mark the journal I/O as sync. ... why I started looking at boosting the priority of the log I/O. ...
    (Linux-Kernel)
  • Re: get_fs_excl/put_fs_excl/has_fs_excl
    ... I/O request is processed? ... I tend to think of it more as an I/O priority issue, and specifically, ... filesystem in a ionice'd process, I could imagine a badly written ... FREEZE ioctl, where the filesystem has been frozen --- the very ...
    (Linux-Kernel)
  • Re: [PATCH] cgroup: limit block I/O bandwidth
    ... solve the priority inversion problem you were seeing earlier. ... Thanks Naveen, I can test you scheduler if you want, but the priority ... inversion problem (or better we should call it a "bandwidth limiting" ... to the I/O scheduler. ...
    (Linux-Kernel)
  • Re: [PATCH] cgroup: limit block I/O bandwidth
    ... solve the priority inversion problem you were seeing earlier. ... Thanks Naveen, I can test you scheduler if you want, but the priority ... inversion problem (or better we should call it a "bandwidth limiting" ... to the I/O scheduler. ...
    (Linux-Kernel)
  • [PATCH 0/1] Correct sorting problem in cfq_service_tree_add
    ... Found this whilst reviewing the CFQ I/O scheduler code: ... sort prioritized queues within a specific class. ... sort to utilize the full I/O priority. ...
    (Linux-Kernel)
Loading