[PATCH 08/13] checkpatch: complex macros checks miss square brackets
- From: Andy Whitcroft <apw@xxxxxxxxxxxx>
- Date: Fri, 3 Oct 2008 16:25:49 +0100
We are missing 'simple' values which include square brackets. Refactor
to ensure we handle nesting correctly and detect these simple forms.
Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxx>
---
scripts/checkpatch.pl | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c479bde..54dfa2b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2142,9 +2142,10 @@ sub process {
$dstat =~ s/\s*$//s;
# Flatten any parentheses and braces
- while ($dstat =~ s/\([^\(\)]*\)/1/) {
- }
- while ($dstat =~ s/\{[^\{\}]*\}/1/) {
+ while ($dstat =~ s/\([^\(\)]*\)/1/ ||
+ $dstat =~ s/\{[^\{\}]*\}/1/ ||
+ $dstat =~ s/\[[^\{\}]*\]/1/)
+ {
}
my $exceptions = qr{
--
1.6.0.1.451.gc8d31
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 00/13] checkpatch: update to version 0.24
- From: Andy Whitcroft
- [PATCH 00/13] checkpatch: update to version 0.24
- Prev by Date: [PATCH 07/13] checkpatch: suspect code indent must stop at #else/#elif
- Next by Date: [PATCH 09/13] checkpatch: DEFINE_ macros are real definitions for exports
- Previous by thread: [PATCH 07/13] checkpatch: suspect code indent must stop at #else/#elif
- Next by thread: [PATCH 09/13] checkpatch: DEFINE_ macros are real definitions for exports
- Index(es):
Relevant Pages
|
