Re: [PATCH] HPET: Remove the BKL.



Andi Kleen wrote:
David John <davidjon@xxxxxxxxxxx> writes:
@@ -586,7 +583,7 @@ static const struct file_operations hpet_fops = {
.llseek = no_llseek,
.read = hpet_read,
.poll = hpet_poll,
- .ioctl = hpet_ioctl,
+ .unlocked_ioctl = hpet_ioctl,

Did this actually compile without warning? unlocked_ioctl has a different prototype than ioctl

-Andi


Argg. I didn't check. :-[. Incidentally, this seems to have been done by Alan here: http://lkml.org/lkml/2008/5/22/350. Was the patch dropped later?

CC'd: Alan Cox

David.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [OT] poll
    ... :: WeeBit wrote: ... ::: I messed up again huh well i can start over if i have too. ... Cheers Alan, T2 d&e, Australia. ... This poll is very active. ...
    (alt.support.diabetes)
  • Re: Redd James
    ... book online called Vegas Lights. ... able to decide for them by voting on the poll. ... Right now you can vote on the female protagnist's name ... Alan. ...
    (misc.writing)
  • Re: [OT] poll
    ... WeeBit wrote: ... ::: I created this poll just to see how people would respond to it. ... ::: am still learning how to do polls so be gentle ok. ... :: Cheers Alan, T2 d&e, Australia. ...
    (alt.support.diabetes)
  • Re: Heidis Poll Results:
    ... Dr. Jai clearly has the best posts in this group, in my opinion. ... Anybody want to start a poll on that? ... Sure, I'll oblige, Alan. ...
    (sci.lang)
  • Re: [OT] poll
    ... >:: Is this better Alan? ... They said Katrina was a wake up call for them. ... This poll is very active. ... Hi Weebit, ...
    (alt.support.diabetes)