Re: [PATCH 0/3] Improve TSC as a clocksource under VMware

On Tue, 2008-10-21 at 11:15 -0700, Andi Kleen wrote:
FWIU from the code, even if cpu A's TSC is just 1 tick behind that of
cpu B, we increment the nr_wraps value.
And the code expects that there are no wraps in TSC throughout the
20msec measurement window.
So IMO its fairly easy to fail this test.

Ok I think it would be better to enlarge the margin then to fix your
issue.


Yeah, i thought about that, but given the different kinds of native
hardware that we have i think coming up with values that would be safe
for all the cases would be difficult. And given that nobody has
complained about this on native until now, i would prefer not to change
the status quo. Apart from that, even on VMware virtualized environment
there can different configurations where this margin keeps on varying,
under different scenarios, f.e. under overcommitment and all. So i don't
think that changing threshold values maybe safe for all cases.

I think going with ignoring this check for specific systems is the best
way to go further. I am open to either having a check for
CONSTANT_TSC or a new flag tsc_reliable (similar to my patch).

I hope you also agree with the CONSTANT_TSC check.

Thanks,
Alok


-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Trailer Weight Over Truck GVWR
    ... The argument is whether going to GVWR/GCWR is safe and 75% is over-safe ... What I think is also a disservice is telling a newbie he must pull a 22ft ... To think that a margin of safety is included with the ratings is just an assumption, just as the requirement to add the margin of safety your self. ...
    (rec.outdoors.rv-travel)
  • Re: Circuit that produces a tingling sensation in the fingers.
    ... or too strong to be safe. ... > of an ICU, with trained medical personnel controlling the apparatus, ... There is a big margin between what can be sensed by the skin and what ... But, of course you need to have a brain to do anything with electricity, ...
    (sci.electronics.basics)
  • Re: Man Charged When His 6 Dogs Kill Little Boy
    ... they often walked places alone. ... seemed as *safe* for our children IMO. ... Samantha Runion was playing outside with a little friend. ...
    (alt.true-crime)
  • Re: What is the real maximum voltage for a BJT?
    ... >>BVcbo or BVcer are safe numbers to use in the real world in most ... >>circuits. ... I assume the manufacturer applies the margin so I don't have ...
    (sci.electronics.design)
  • Re: [PATCH 0/3] Improve TSC as a clocksource under VMware
    ... Ok I think it would be better to enlarge the margin then to fix your ... flavours and if each of them adds their own detection code Linux will soon ... think that changing threshold values maybe safe for all cases. ... although the question is how much sanity ...
    (Linux-Kernel)