Re: [PATCH 1/7] Adding empia base driver

On Thu, Oct 23, 2008 at 12:24:31AM +0200, Markus Rechberger wrote:
On Thu, Oct 23, 2008 at 12:09 AM, Greg KH <greg@xxxxxxxxx> wrote:
On Wed, Oct 22, 2008 at 11:14:36PM +0200, Markus Rechberger wrote:
em2880-dvb:
* supporting the digital part of Empia based devices, which
includes ATSC, ISDB-T and DVB-T

<snip>

Doesn't this driver duplicate some of the existing devices we already
support with the current in-kernel driver? If so, why not just add the
new device support to the existing driver instead of duplicating
everything?

This is going to cause a big problem for distros as they will not know
which to enable, so they will probably just disable this one, which is
what I don't think you want to have happen :(


the current driver doesn't support most devices which are in there,

Then why not just add new device support to the existing one?

also the alsa audio driver can easily crash the whole system. (It's my
code so I know what was wrong there).

Why not send patches to fix it?

Very likely the best would be to replace the available driver with it
but I don't care, alot people use and have been using the driver from
mcentral.de for a long time, development has always been opensource
there too.

Dropping existing code and replacing it entirely with a new base is not
how Linux kernel development works for the most part.

How about just sending patches in an incremental way, fixing problems in
the current driver that you know about, and adding support for all of
this goodness as well? That's what all 2000+ other kernel developers
do when they want to make changes like this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • [GIT]: Networking
    ... maintainer making a lot of changes to driver FOO. ... support for networking. ... iwl3945: Fix iwl3945 rate scaling. ... Fix build warning due to typo in %pI4 format changes. ...
    (Linux-Kernel)
  • [GIT]: Networking
    ... Make VLAN and MACVLAN drivers support multiqueue, ... Return type of net driver xmit routines is formalized into ... Lots of bluetooth fixes and cleanups from Marcel Holtmann ... Fix premature termination of FIN_WAIT2, ...
    (Linux-Kernel)
  • [GIT]: Networking
    ... RFKILL rewrite from Johannes Berg. ... IPV6 stateless autoconfig support for ISATAP, ... fix led bug when SW rfkill ... Add watchdog functionality to hfcmulti driver ...
    (Linux-Kernel)
  • Re: CD/DVD drive errors and lost ticks
    ... Try and pass ide=noprobe option to the kernel boot command line and see if that makes a difference first - may be that will allow the SATA/PATA drivers to claim the CDROM before IDE sees it. ... # ACPI Support ... # PCI Hotplug Support ... # Generic Driver Options ...
    (Linux-Kernel)
  • OPL3SA2: spin_is_locked on uninitialized spinlock
    ... I've found a lot of errors like this when loading the OPL3SA2 sound ... driver on my old Intel AL440LX computer, ... compile the kernel. ... # ACPI Support ...
    (Linux-Kernel)