Re: Bug fix for pvrusb2 driver [was: Re: Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D_STATE)]

On Thu, Oct 23, 2008 at 3:54 PM, Mike Isely <isely@xxxxxxxxx> wrote:
On Thu, 23 Oct 2008, Greg KH wrote:

On Thu, Oct 23, 2008 at 11:27:11AM -0500, Mike Isely wrote:
On Mon, 20 Oct 2008, Greg KH wrote:


[...]


Will this patch be sent to the -stable group, to fix this regression in
2.6.27? Or should they take Alan's fix instead?


Greg:

I didn't directly answer your question here because I had figured it was
answered in a previous post on this thread, that Mike Krufky had already
explicitly asked that it be queued (and added his Reviewed-By tag), and
that I figured it best not to add yet more noise to an already noisy
group.

However now I see that this patch didn't get into 2.6.27.3. It's a
pretty important fix; without it the pvrusb2 driver is worse than
useless (unless one adds initusbreset=0 as a module option).

As we were discussing this on Monday, and the review cycle for 2.6.27.3
started last Saturday, it would have been pretty hard to get it into
2.6.27.3 :)

I need to see the patch in Linus's tree first, before it can go into any
stable release. Is it in there yet? If so, please send me the git
commit id and I'll queue it up for the next -stable round.


OK, I understand.

As far as I know, Linus has not yet pulled the changes from Mauro (part
of a larger set). But that information is a few hours old. I or Mike
Krufky will let you know if/when one of us finds out.

Thanks for following up.

-Mike

Mike,

Have you tested to confirm that FX2 firmware download without USB
reset still leaves the DTV firmware commands operable?

In other words, I'm not entirely sure about this fix. If both Digital
and Analog still work with the patch included, then as far as I am
concerned, its fine for stable.

Greg, this is already in Linus' tree as of a few hours ago. I had
already cherry-picked it and had planned to send it off to you after
testing it myself, but I probably wont get to that until Saturday or
Sunday.

If Mike Isely can confirm that Digital modes still work on the HVR1950
after a firmware download without an FX2 reset, then we don't need to
wait for my own testing.

The changeset in Linus tree is: c82732a42896364296599b0f73f01c5e3fd781ae

Reviewed-by: Michael Krufky <mkrufky@xxxxxxxxxxx>

Please wait on test results from Mike Isely or I confirming that
digital mode still works properly before queuing this one.

Thanks,

Mike Krufky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages