Re: [UPDATED PATCH VER2] Cell OProfile: Incorrect local array size in activate spu profiling function

On 29.10.08 08:06:45, Carl Love wrote:
Updated the patch to address comments by Michael Ellerman.
Specifically, changed upper limit in for loop to
ARRAY_SIZE() macro and added a check to make sure the
number of events specified by the user, which is used as
the max for indexing various arrays, is no bigger then the
declared size of the arrays.

The size of the pm_signal_local array should be equal to the
number of SPUs being configured in the array. Currently, the
array is of size 4 (NR_PHYS_CTRS) but being indexed by a for
loop from 0 to 7 (NUM_SPUS_PER_NODE).

Signed-off-by: Carl Love <carll@xxxxxxxxxx>

I applied your patch to oprofile/oprofile-for-tip. Thanks Carl.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Macro running slow
    ... ' Macro to return heights of Rows 1-6 to their preset heights ... But I have to question why row heights need to be adjusted in a macro. ... read the range into an array and loop through the ...
    (microsoft.public.excel)
  • Re: Q re program speed, with 15k lines of data
    ... i didn't attribute much to the vlookup when the macro ... before the loop, not auotmatic as i stated in my firt post. ... Maybe what can speed this up is putting the data in an array, ...
    (microsoft.public.excel.programming)
  • RE: Pivot table Macro
    ... What does Name, Size, Color, Logo, and S_Number include? ... you loop through array elements via a For Each Next or For Next ... The current macro includes it thus messing up my formatting. ...
    (microsoft.public.excel.programming)
  • Re: (loop for foo across bar) and multiple-dimensional arrays
    ... | I noticed that both SBCL and CLISP refuse to iterate over multi-dimensional ... Go to 6.2 The Iteration Dictionary and read about the Macro LOOP ... which defines a vector to be a one-dimensional array. ...
    (comp.lang.lisp)
  • Re: Problems with multidimensional arrays and global variables
    ... Carl wrote: ... the dimensioning line is in the ... >> guessing is due to the scope of the array. ... > This should most likely be handled in the constructor or a helper method. ...
    (comp.lang.java.help)