[patch 48/49] hfs: fix namelength memory corruption (CVE-2008-5025)
- From: Greg KH <gregkh@xxxxxxx>
- Date: Tue, 11 Nov 2008 16:24:35 -0800
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: Eric Sesterhenn <snakebyte@xxxxxx>
commit d38b7aa7fc3371b52d036748028db50b585ade2e upstream
Fix a stack corruption caused by a corrupted hfs filesystem. If the
catalog name length is corrupted the memcpy overwrites the catalog btree
structure. Since the field is limited to HFS_NAMELEN bytes in the
structure and the file format, we throw an error if it is too long.
Cc: Roman Zippel <zippel@xxxxxxxxxxxxxx>
Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
---
fs/hfs/catalog.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/fs/hfs/catalog.c
+++ b/fs/hfs/catalog.c
@@ -190,6 +190,10 @@ int hfs_cat_find_brec(struct super_block
fd->search_key->cat.ParID = rec.thread.ParID;
len = fd->search_key->cat.CName.len = rec.thread.CName.len;
+ if (len > HFS_NAMELEN) {
+ printk(KERN_ERR "hfs: bad catalog namelength\n");
+ return -EIO;
+ }
memcpy(fd->search_key->cat.CName.name, rec.thread.CName.name, len);
return hfs_brec_find(fd);
}
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [patch 00/49] 2.6.27.5 stable review
- From: Greg KH
- [patch 00/49] 2.6.27.5 stable review
- Prev by Date: [patch 49/49] HID: fix incorrent length condition in hidraw_write()
- Next by Date: [patch 47/49] hfsplus: check read_mapping_page() return value (CVE-2008-4934)
- Previous by thread: [patch 49/49] HID: fix incorrent length condition in hidraw_write()
- Next by thread: [patch 47/49] hfsplus: check read_mapping_page() return value (CVE-2008-4934)
- Index(es):
Relevant Pages
|
Loading
