Re: Fix broken ownership of /proc/sys/ files



On Mon, 17 Nov 2008, Al Viro wrote:

We already initialize a _lot_ of fields, including fields that most
filesystem would likely end up re-initializing when reading an inode (like
i_size and i_nlink). Maybe it would be more sensible to initialize
i_gid/uid there too, when we are guaranteed to have that cacheline dirty
anyway (because we're initializing everything around those fields).

*nod*

It certainly makes sense to do it in a uniform way - there's enough
users of new_inode() that want exactly that. I'll do that as soon
as I get from under a huge pile of pending mail ;-/

Ok. I think zeroing i_mode might be a good idea too. Just to make sure..

ObPendingStuff: would you mind a series of section annotations? That's
a bunch of trivial one-liners and it kills the section noise - the remaining
ones are few and tricky. It had sat around in my tree for several weeks
and I can certainly carry it until the next cycle, but OTOH this stuff
*is* trivial and the noise is annoying as hell.

Yeah, it would be good to get rid of at least the bulk of the section
warnings. A lot of them have historically been 100% real problems.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Fix broken ownership of /proc/sys/ files
    ... really core members. ... We already initialize a _lot_ of fields, ... a bunch of trivial one-liners and it kills the section noise - the remaining ... *is* trivial and the noise is annoying as hell. ...
    (Linux-Kernel)
  • Re: k&r 1-13
    ... On Sat, 14 Feb 2004, Rob Somers wrote: ... > I have not been reading this group for very long, so forgive me if this is ... and did you initialize the elements of 'word_freq' to zero ... How am I to know, et cetera, et cetera. ...
    (alt.comp.lang.learn.c-cpp)
  • Re: Getting valid Integer values !!
    ... Frank Randolph CIV" wrote in message ... It's always good to initialize your variables, ... The compiler warns you that you are reading from a variable before ... variable before writing it. ...
    (comp.lang.ada)
  • Re: simple(ish) matlab calculations (help needed please)
    ... ch00se wrote in message ... been reading the manual and trying to initialize it within ... the application but am having no luck ...
    (comp.soft-sys.matlab)
  • I think I found a mistake in the official language reference documentation -- or I am missin
    ... Reading the section "6.11. ... initialize it if necessary; define a name or names in the local ... The first form repeats these steps for each identifier ... Or am I missing something????? ...
    (comp.lang.python)