Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 26 Nov 2008 00:35:53 -0800
On Wed, 26 Nov 2008 00:27:04 -0800 Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
if (code[0] != 0xe9 || old_offset != load32_noalign(&code[1]))
This is similar to the new API in -mm load_le32_noalign, but I
don't think it would be worth load_u32_noalign...load32 should
be enough.
+ return -EINVAL;
+
+ *(int *)(&code[1]) = new_offset;
Might be able to use put_unaligned_foo() here.
put_unaligned(new_offset, (int *)(&code[1]));
In a similar vein to above, this becomes:
store32_noalign(&code[1], new_offset);
yes, that's much better than the party tricks with magical sizeof,
which forces you to run around and check the types of everything.
I've seen people doing get_user() on `long' types and such things
occasionally.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- From: Harvey Harrison
- Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- References:
- [PATCH 0/5] ftrace: rebase patches on top of tip/master + some extras
- From: Steven Rostedt
- [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- From: Steven Rostedt
- Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- From: Andrew Morton
- Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- From: Harvey Harrison
- Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- From: Andrew Morton
- Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- From: Harvey Harrison
- [PATCH 0/5] ftrace: rebase patches on top of tip/master + some extras
- Prev by Date: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken
- Next by Date: Re: ndiswrapper 1.54-2.6.27 released
- Previous by thread: Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- Next by thread: Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer
- Index(es):
Relevant Pages
|
