Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822

On Sun, Nov 30, 2008 at 02:52:21PM +0000, Al Viro wrote:
On Sun, Nov 30, 2008 at 03:28:15PM +0100, Kay Sievers wrote:
So we need to preserve the layout, with the easiest way probably being "add
one more ktype and use kobject_init_and_add() instead of that device_create()".
Sigh...

What do you mean? We just need to replace the bogus "pd->pkt_dev" with
MKDEV(0, 0) and we are fine.

Userland-visible change - right now cat /sys/class/pktcdvd/pktcdvd3/dev will
give you dev_t of the block device in question.

Looking at the locking scheme there, it appears that we have an unpleasant
race of the same kind as discussed in md-with-eviction thread. If removal
hits between finding (and grabbing) gendisk and actual call of ->open(),
it will succeed just fine and we might get an open for _different_ object,
while holding a reference to disk that had already gone through del_gendisk().
Call ioctl() on that sucker and you've got
struct pktcdvd_device *pd = bdev->bd_disk->private_data;
which will point to already freed object.

It really appears that we need to
* add ->use() and ->unuse() callbacks
* have exact_lock() call ->use() in addition to get_disk() - either
on each hit, or on the "it's currently not in use" ones.
* have ->unuse() called on failure exits in __blkdev_get() and in
blkdev_put(), with rules matching those for calls of ->use().

That would allow to close that kind of races, both here and in md. I'd
probably prefer the second variant for calling rules - we would be able
to bracket the "it's associated with underlying objects" intervals by
those calls... Hell knows; I really need to get some sleep and look through
the ->open() and ->release() instances for block devices. Later...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: OK now STERN- wheres that Led Zeppelin pin??
    ... out hits just a few years ago. ... Same with Outkast. ... mainstream that sells album after album. ... he is liked by many race and income levels. ...
    (rec.games.pinball)
  • Re: NBC adds "Fear Factor" to Summer, drops "Four Kings"
    ... Reality shows like Survivor, The Amazing Race, and Dancing with the ... Stars were all introduced in the summer season, proved to be hits, and ... Of course, CBS ...
    (rec.arts.tv)
  • Re: holding game about to collapse...
    ... a holding game from 4 points away is not nearly as strong as a holding game from 6 points away. ... I view it as weak enough that I'd rather take my chances on an exchange of hits - O has a three point board with two blots while X has a full board, and I like that better than the race that's likely to ensue after making the 18. ...
    (rec.games.backgammon)
  • Re: #25 GNUBG 2-ply or BG GIANT
    ... X is still significantly behind in the race after this roll, ... - keeping the midpoint while he can do this without wasting pips by ... than making lower points. ... If he hits a checker, ...
    (rec.games.backgammon)