[patch-rt 5/5] trace: warn if irqs already enabled in irqs_off latency check



Be consistent: Warn if irqs are already enabled in irqs_off latency
processing, same as in preempt_off and in irqs_off && preempt_off. This
warning can now safely be inserted, after a problem was fixed that
caused false positives.

Signed-off-by: Carsten Emde <C.Emde@xxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>


---
kernel/trace/trace_hist.c | 1 +
1 file changed, 1 insertion(+)

Index: linux-2.6.26.8/kernel/trace/trace_hist.c
===================================================================
--- linux-2.6.26.8.orig/kernel/trace/trace_hist.c
+++ linux-2.6.26.8/kernel/trace/trace_hist.c
@@ -356,6 +356,7 @@ notrace void tracing_hist_preempt_stop(i
#ifdef CONFIG_INTERRUPT_OFF_HIST
if (irqs_on &&
per_cpu(hist_irqsoff_tracing, cpu)) {
+ WARN_ON(!irqs_disabled());
stop = ftrace_now(cpu);
stop_set++;
start = per_cpu(hist_irqsoff_start, cpu);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: dcdiag - replication Concerns
    ... Last replication recieved from Server1 at 2009-03-30 ... WARNING: This latency is over the Tombstone Lifetime ...
    (microsoft.public.windows.server.active_directory)
  • Re: Re: 5.3-RELEASE: WARNING - WRITE_DMA interrupt timout - what does it mean?
    ... > Either way its a WARNING not a FAILURE:) ... I'm still a bit skeptical that the task queue is at fault -- I run my ... notebook with continuous measurement of the latency to schedule tasks, ... +int tq_out; ...
    (freebsd-current)
  • dcdiag - replication Concerns
    ... REPLICATION-RECEIVED LATENCY WARNING ... Last replication recieved from Server1 at 2009-03-30 ... This latency is over the Tombstone Lifetime of 60 ...
    (microsoft.public.windows.server.active_directory)
  • Re: AD Replication - DCDIAG
    ... As Jorge Pinto said you probably didn't monitor the replication at regular ... REPLICATION-RECEIVED LATENCY WARNING ... This latency is over the Tombstone Lifetime of 60 ...
    (microsoft.public.windows.server.active_directory)
  • Re: [PATCH 1/3] Separate IRQ-stacks from 4K-stacks option
    ... above you only talk about scheduler latency. ... because nothing could run but other IRQs. ... The issue IIRC was the potential for stack overflow with 4K stacks if we ...
    (Linux-Kernel)