Re: [patch] mm: Fix SHM_HUGETLB to work with users in hugetlb_shm_group

On Thu, Feb 05, 2009 at 01:25:29PM +0000, Mel Gorman wrote:
This should be split into another patch (i.e. three in all). The
first patch allows users in thh shm_group to use huge pages. The
second that accounts for locked_shm properly. The third allows
users with a high enough locked rlimit to use shmget() with
hugepages. However, my feeling right now would be to ack 1,
re-reread 2 and nak 3.

I'm saying to ack all 3 for backward compatibility reasons, once
they're fixed up according to your other commentary.

On Thu, Feb 05, 2009 at 11:08:51AM -0800, Ravikiran G Thirumalai wrote:
I totally agree. In fact yesterday I was thinking of resending
this patch to not account for shm memory when a user is not
validated against rlimits (when he has CAP_IPC_LOCK or if he
belongs to the sysctl_hugetlb_shm_group).
As I see it there must be two parts:
1. Free ticket to CAP_IPC_LOCK and users belonging to
sysctl_hugetlb_shm_group
2. Patch to have users not having CAP_IPC_LOCK or
sysctl_hugetlb_shm_group to check against memlock
rlimits, and account it. Also mark this deprecated in
feature-removal-schedule.txt
Would this be OK?

This is the ideal scenario, except I thought the rlimit was destined
to replace the other methods, not vice-versa. I don't really mind
going this way, but maybe we should check in with the rlimit authors.


-- wli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [-mm][PATCH 0/4] Add rlimit controller to cgroups (v3)
    ... This is the third version of the address space control patches. ... The first patch adds the user interface. ... could you add design hint of rlimit contoller to the documentation? ...
    (Linux-Kernel)
  • Re: IIS Server default user account reset after patching?
    ... no patch should reset these settings. ... security templates, or restore a metabase? ... The application was configured with a local user> account on each node in the cluster and has been working correctly since ... This week 2 situations occured that caused both nodes in the> cluster to fail simultaniously. ...
    (microsoft.public.inetserver.iis.security)
  • Re: remote users cannot authenticate to our intranet webpage
    ... >> I have been having a problem with remote users not being ... >> able to log into our intranet website. ... >> then get a login popup where they enter their account ... we uninstalled the patch ...
    (microsoft.public.inetserver.iis.security)
  • Re: disable-cap-mlock
    ... >> This is a lot simpler than the mlock rlimit and this is people really ... > This patch isn't usable for that at all, ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [PATCH] fix for sched_clock() when using jiffies
    ... Account for the initial offset to the jiffy count. ... This was a resend of a patch that seemed to get a thumbs up, ...
    (Linux-Kernel)