Re: [PATCH] modpost: Check the section flags, not name, to catch missing "ax"/"aw"

Anders Kaseorg wrote:
On Tue, 24 Feb 2009, H. Peter Anvin wrote:
This is a pretty critical set of warnings, that often represent real
bugs. I don't think it's acceptable to lose them. However, you already
have (prior in the sequence) changed those section names to not conflict
with the automatically generated ones, so it seems to me that this
should be fixable without too much pain.

Actually, the problem arises from a conflict between two classes of
automatically generated section names, one from ld, and one from gcc.
Instead of basing the warning on section names (the existing heuristic
also fails to warn on some cases where it should, as it turns out), what
do you think about this patch? I've tested that it still triggers the
warning when an "ax" or "aw" is incorrectly removed, and it should handle
even more cases than before.


Seems reasonable to me.

-hpa


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: How to Determine Name of the Day in the Week
    ... to think of Monday as day 0 of the week and it doesn't conflict with any ... prior date format. ... the Lithuanian calendar simple enumerates the days of the ...
    (comp.lang.python)
  • Re: Cantors definition of set
    ... of the signs we use to portray numbers, ... arranged in a sequence and not numbers after all? ... There's no conflict in a set being of a certain KIND. ... The collection of coins would ...
    (sci.logic)
  • Re: Zone Alarm XP problem
    ... So these people have an application conflict! ... deleted or archived prior to installing ZA? ... Prev by Date: ...
    (microsoft.public.windowsxp.general)
  • Re: Cantors definition of set
    ... of the signs we use to portray numbers, ... arranged in a sequence and not numbers after all? ... There's no conflict in a set being of a certain KIND. ... The collection of coins would ...
    (sci.logic)
  • Interesting problem
    ... You also have a relation which describes proper sequence of this integers. ... there is an 'conflict' in sequence with the relation,cost is calculated. ... I have to find an permutation of sequence with the lowest cost in shortest ... calculating cost..) ...
    (comp.theory)
Loading