Re: tip: bzip2/lzma now in tip:x86/setup-lzma


* Alain Knaff <alain@xxxxxxxx> wrote:

Alain Knaff wrote:
Alain Knaff wrote:
hmmm, but on a second glance, there seems to be indeed an issue. When
compiling it a _second time_, compilation will "succeed" but produce a
bad kernel because the first attempt left an empty
usr/initramfs_data.cpio.bz2 .

I'll look into it this evening, probably a case of "bad" failure
recovery in the Makefile.


Took me slightly longer than promised, attached is the patch.

It changes/fixes three things:
1. Fix a bug in decompress.c : only scanned until the first
non-configured compressor (with disastrous result if that was gzip)
2. Fix a bug in gen_initramfs_list.sh : in case of failure, it left
indeed an empty output file behind, messing up the next make.
3. Make builtin initramfs compression configurable

Regards,

Alain


Any comments about this? Ingo, does it solve the issue with
randconfig?

I've reactivated tip:x86/setup-lzma in tip:master and started
testing it with the problem .config, on the problem test-system.
The bug is most likely fixed, so consider it queued up for
2.6.30 unless i report some new issue.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: tip: bzip2/lzma now in tip:x86/setup-lzma
    ... Fix a bug in gen_initramfs_list.sh: in case of failure, ... indeed an empty output file behind, ... Make builtin initramfs compression configurable ...
    (Linux-Kernel)
  • Re: use assert and defensive together
    ... It would be better if you used different return codes for each type of failure, but I'm not going to fix al of your code. ... because the calling program is notified and will report to the user that it failed and if the calling program is any good at all will report the reason for the failure. ... But by confusing programming errors with incorrect paths, you are bug hiding. ... The function is therefore incorrect because it should use them or incorrect because it takes them. ...
    (comp.lang.c)
  • Re: just a warning?
    ... connection can have this problem if there's a transient failure ... connection, but haven't seen it since installing dapper. ... grep - GNU grep, egrep and fgrep ... the bug will be fixed in breezy one day. ...
    (Ubuntu)
  • Re: Generic-Package Elaboration Question / Possible GNAT Bug.
    ... As for randomly raised exceptions from dynamic checks, ... efforts in Ada 95 was spent on catching accessibility checks faults. ... If the program has a bug its execution is erroneous. ... How would you notice a failure to notice? ...
    (comp.lang.ada)
  • Re: What to do with a failed automated test
    ... one of then is failing. ... After discussion, the bug is ... report that was produce base on the initial failure. ...
    (comp.software.testing)