Re: [PATCH 10/58] move corgi-ssp's probe function to .devinit.text
- From: Eric Miao <eric.y.miao@xxxxxxxxx>
- Date: Sat, 28 Mar 2009 17:31:05 +0800
2009/3/28 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>:
A pointer to corgi_ssp_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (when having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
These files are supposed to be deprecated and I'm planning to remove
them once drivers/input/touchscreen/corgi-ts.c begins its migration to
ads7846.c (with a posted fix currently queued in the -mm tree). Other
than corgi-ts.c, there will be no reference to them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [RESENT] platform_driver's probe functions must not be located in .init.text
- From: Uwe Kleine-König
- [PATCH 10/58] move corgi-ssp's probe function to .devinit.text
- From: Uwe Kleine-König
- [RESENT] platform_driver's probe functions must not be located in .init.text
- Prev by Date: Re: [PATCH 23/58] move jornada_ssp's probe function to .devinit.text
- Next by Date: Re: [PATCH 47/58] move sharpsl-pm's probe function to .devinit.text
- Previous by thread: [PATCH 10/58] move corgi-ssp's probe function to .devinit.text
- Next by thread: [PATCH 06/58] move bf54x-lq043's probe function to .devinit.text
- Index(es):
Relevant Pages
|
Loading