Re: [PATCH 2/2] Move FAULT_FLAG_xyz into handle_mm_fault() callers



On Fri, 10 Apr 2009, Ying Han wrote:

How about something like this for x86? If it looks sane, i will apply
to other arches.

Eventually yes, but only _after_ doing the "mindless patch".

I really want the patches that change calling conventions to "obviously"
do nothing else (sure, they can still have bugs, but it minimizes the
risk). Then, _after_ the calling convention has changed, you can do a
separate "clean up" patch.

+ unsigned int fault_flags |= FAULT_FLAG_RETRY;

I assume you meant "fault_flags = FAULT_FLAG_RETRY;", ie without the "|=".

But yes, other than that, this is the kind of patch that makes sense -
having the callers eventually be converted to not use that "write" kind of
boolean, but use the FAULT_FLAG_WRITE flags themselves directly, and then
eventually have no "conversion" between the boolean and the fault_flag
models at all.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages