Re: Fix quilt merge error in acpi-cpufreq.c



On Thu, 16 Apr 2009, Ingo Molnar wrote:

So would a:

The impact of this change: it is a pure cleanup.

Formalization be acceptable? We tried to make it short and fit into
a single line - but we can certainly make it longer.

Language is not a "fit to one string" thing.

It doesn't matter what the string is: if you haev a fixed format, it's not
human language. It's that easy.

Don't make up stupid fixed-format rules, and most certainly don't make
them make the real payload harder to tread.

If people write "The impact of this is to fix compilation", then that's
fine as an occasional thing, although it's damned stilted English, and I
certainly wouldn't ever recommend it. Why not just say

This fixes a compile problem in file so-and-so.

instead? Much clearer to everybody.

You just dont seem to understand why i find it useful. You also seem
to try to deprive us the basic right of creating new, field-specific
language variants we find useful in our everyday work. And that
sucks.

YOU HAVE NEVER GIVEN A COHERENT REASON FOR FINDING IT USEFUL!

Yes, you bring up the same reason every time: namely that you want to know
what the patch does. But never _once_ have you given a reason fo why that
fixed-format string helps at all.

That's what i've been trying to tell you: don't use stilted and artificial
fixed formats where it doesn't make sense.

Instead of

Impact: cleanup

just write

Cleanup xyz by doing abc

which is MORE informational, and much easier for everybody to read.

That's all I'm asking. Stop making the commit messages harder to read,
uglier, and less informative.

[ And if it's purely for "grep", then you can damn well hide it at the end
where nobody sane cares any more, but you seem to not have been able to
acknowledge that if it's for 'grep', then you're _missing_ all the
changes that don't have that string in the first place, so that's not a
very good reason _either_. ]

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Controlling Javascript from server side
    ... but five different language implementations here. ... 'true' means that the request must be handled asynchronously. ... There is exactly *no* reason for such a thing here. ... | percent-endoded string). ...
    (comp.lang.javascript)
  • Re: question on alternate function declaration syntax
    ... > think of a reason why it would cause problems (besides it being ... language grammars are written in a way that having no spaces between ... then the string to apply to the function. ... to "find" other than RootsOf. ...
    (comp.lang.java.programmer)
  • Re: (simple) question - function calls without ()
    ... reason for it. ... However setTimeout is being passed ... a string in this case and knows nothing about the ... not part of the actual language and so not in ECMAScript ...
    (comp.lang.javascript)
  • Re: Is C++ the "General Motors" of Programming Languages?
    ... On 22 Nov 2008 16:57:01 GMT, Bill Gunshannon wrote: ... I also see no reason why something like that needs to be a part of ... You can basicly define a string any way you want. ... I don't care if they come from the language, ...
    (comp.lang.misc)
  • Re: Is that a good design?
    ... I would have been able to reason the first gotcha. ... public string FirstName; ... has a reference architecture that shows the use of patterns. ... Public Shared Function GetUserInstance() As User ...
    (microsoft.public.dotnet.framework)