Re: [PATCH] hda_intel.c - Consolidate bitfields

At Wed, 15 Apr 2009 11:39:01 -0700,
Joe Perches wrote:

Commit fa00e046b41663cbda9b1affc0594669e5f14219
added a new bitfield not adjacent to other
bitfields in the same struct. Moved the new one.

Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Applied to sound git tree now. Thanks.


Takashi


diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index bc882f8..21e99cf 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -312,7 +312,6 @@ struct azx_dev {
unsigned int period_bytes; /* size of the period in bytes */
unsigned int frags; /* number for period in the play buffer */
unsigned int fifo_size; /* FIFO size */
- unsigned int start_flag: 1; /* stream full start flag */
unsigned long start_jiffies; /* start + minimum jiffies */
unsigned long min_jiffies; /* minimum jiffies before position is valid */

@@ -333,6 +332,7 @@ struct azx_dev {
unsigned int opened :1;
unsigned int running :1;
unsigned int irq_pending :1;
+ unsigned int start_flag: 1; /* stream full start flag */
/*
* For VIA:
* A flag to ensure DMA position is 0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Checking endianess in compile time
    ... > unsigned int tffca: 1; ... > Is there a way to check if the compiler considers bitfield ten to be ... I would like to have the compiler give an error message ( ... Since you care about the exact representation of the bitfield, ...
    (comp.lang.c)
  • Re: GCC bitfield packing
    ... Will the base type of bitfield declaration affect the ... In this example, it uses "unsigned int a:1", what will happen if I ... change it to "unsigned char a:1". ... specify the minimum storage for a bitfield? ...
    (comp.std.c)
  • Re: Question about bit-fields and portability
    ... unsigned int val1: 1; ... How can such a bit-field struct be used in a non portable way? ... network) and then try to restore it on a platform with different ... or that a plain int bitfield of 1 bit can have two ...
    (comp.lang.c)
  • Re: Variable declaration followed by colon?
    ... bitfield that occupies 6 bits; ... Here's the IP header struct that's used in every packet: ... unsigned int version:4; ... What correction and what about unsigned char? ...
    (comp.lang.c)
  • Re: !!, what is it?
    ... >> int bitfield could be treated as if it was an unsigned int ... It is possible for a signed int bitfield to behave as though ... it holds an unsigned int bitfield value. ... trap representations. ...
    (comp.lang.c)