Re: [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup patches

Hello, Bartlomiej.

Bartlomiej Zolnierkiewicz wrote:
From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Subject: [RFC][PATCH] mg_disk: fix issue with data integrity on error in mg_write()

We cannot acknowledge the sector write before checking its status
(which is done on the next loop iteration) and we also need to do
the final status register check after writing the last sector.

Fix mg_write() to match mg_write_intr() in this regard.

While at it:
- add mg_read_one() and mg_write_one() helpers
- always use MG_SECTOR_SIZE and remove MG_STORAGE_BUFFER_SIZE

Cc: unsik Kim <donari75@xxxxxxxxx>
Cc: Tejun Heo <tj@xxxxxxxxxx>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

I folded other three patches into my series. This one looks good to me
too but unlike others this one actually changes how the driver
interacts with the device so I think it would be better to wait for
unsik's ack on this one (I'm pushing out others).

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup patches
    ... Bartlomiej Zolnierkiewicz wrote: ... Subject: mg_disk: fix issue with data integrity on error in mg_write ... We cannot acknowledge the sector write before checking its status ... Fix mg_writeto match mg_write_intrin this regard. ...
    (Linux-Kernel)
  • [PATCH][RESEND] mg_disk: fix issue with data integrity on error in mg_write()
    ... Subject: [PATCH] mg_disk: fix issue with data integrity on error in mg_write ... We cannot acknowledge the sector write before checking its status ... Fix mg_writeto match mg_write_intrin this regard. ... unsigned int sect_num, ...
    (Linux-Kernel)
  • Re: SuSe 9.3: Bad sector on XFS volune, how to fix? CONCLUSION.
    ... and it necesarry fix bad sectors. ... Did not find a bad sector. ... Also it would make sense to only install SUSE on an healthy partition ...
    (alt.os.linux.suse)
  • chkdsk
    ... I discovered I have a bad sector on my hard drive ... (Acronis True Image couln't create an image) ... CHKDSK to fix it. ... However, on Startup, I get the error ...
    (microsoft.public.windowsxp.perform_maintain)
  • [PATCH] Fix cdrom error handling in 2.6
    ... In both 2.4 and in 2.6, error handling for bad cdrom media is ... fix for the problem by putting the fix in the wrong spot. ... sector copy is about 2 years... ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)