Re: Class device namespaces

On Wed, Apr 29, 2009 at 05:19, Michael Brown <mebrown@xxxxxxxxxxxxxxxxxx> wrote:
On Tue, Apr 28, 2009 at 8:42 PM, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
On Tue, Apr 28, 2009 at 23:58, Doug Warzecha <Douglas_Warzecha@xxxxxxxx> wrote:
On Tue, Apr 28, 2009 at 07:46:57PM +0200, Kay Sievers wrote:
On Tue, Apr 28, 2009 at 19:39, Doug Warzecha <Douglas_Warzecha@xxxxxxxx> wrote:

/sys/class/firmware/dell_rbu/loading
/sys/class/firmware/dell_rbu/data

These pathes only ever exist for a fraction of a second, during a
kernel initiated firmware request. This request is usually only
handled by the udev firmware loader script, and not interesting for
anything else. Are you replacing the udev firmware script here? Are
you sure you do something else here?

A Dell library writes data to those paths when a Dell BIOS Update Package is run and requests the BIOS image to be loaded into memory.

How do you do this? These paths exist for a short time only. How do
you get udev out of your way handling the firmware request for you?
How do you plug into the event processing with a custom tool?

Overall, the interface is pretty pathetic because it doesnt fit our
use case *at all*, but way back in the day that is what we had to do
to get it reviewed and approved for merge upstream. At least it is
better than the earlier versions where we had to do a separate
request_firmware() for every 4k packet (and spin waiting for files to
disappear/reappear)

It handles huge files just fine, since the beginning. The space is
realloced in the kernel. I have a modem which loads 200kb files since
years.

All this code is in libsmbios(*) if you want to see the ugly details,
but the short version is this:

1) we poke the image_type file and packet_size files with appropriate
data, which causes the driver to do a request firmware
2) spin until request_firmware creates the files we need

This is totally insane!

2) loop over our file packet_size bytes at a time writing data into
the data file
3) set loading to 0 when done

*) src/python/libsmbios_c/rbu_update.py

The code basically "packetizes" the bios update into page-sized chunks
with a header so BIOS can find them and reassemble them for the final
update.

For older systems (monolithic mode), the kernel code has to allocate
physically contiguous region to hold the entire firmware image.

Yeah, maybe you can not use the in-kernel firmware-request filled
memory. But you can copy it just fine, once it is in the kernel. There
is no reason to fiddle around with chunks here in userspace.

How do you make sure udev does not handle the request at the same
time? This interface is not public at all, on a general system. As
long as udev is active you can not use it at all. Udev will run at the
same time and write to the same files, and even cancel the request if
the requested file is not found. How does your software cope with
that?

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Documentation for sysfs, hotplug, and firmware loading.
    ... hotplug, populating /dev, and things like firmware loading that fall out ... This requires use of sysfs, and I'm only trying to document as ... and reinventing udev for their own enjoyment would not at least look at ... kernel to work with an old udev, and they say it with a straight face. ...
    (Linux-Kernel)
  • Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
    ... abstract mechanism that can request a firmware file. ... It is not the agreed contract between kernel and userspace. ...
    (Linux-Kernel)
  • Re: Class device namespaces
    ... request_firmwarefor every 4k packet (and spin waiting for files to ... which causes the driver to do a request firmware ... physically contiguous region to hold the entire firmware image. ... long as udev is active you can not use it at all. ...
    (Linux-Kernel)
  • Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
    ... abstract mechanism that can request a firmware file. ... It is not the agreed contract between kernel and userspace. ...
    (Linux-Kernel)
  • Re: DLINK 614+ - SOHO routers, system DOS
    ... the flaws reported to DLINK on May 24th and posted to bugtraq have ... Rev A's latest firmware available is still 2.30 and therefore IS ... | left in an unstable state immediately followed by a system reboot. ... | along with the request or if no ip address is available for dynamic ...
    (Bugtraq)