Re: Probe Timeouts with 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8



On Mon, 2009-05-11 at 10:57 -0700, Linus Torvalds wrote:

Ok, it's -rc5, and apparently nothing has happened about this problem.
Johannes has just been stone-walling and ignoring the reports, and
claiming it's fixed when it clearly wasn't.

?
I always only said it was fixed in wireless-testing and that the fix was
on the way upstream. I have no influence over more. And I worked with
Parag in the bugzilla bug to fix the other bug he was seeing on
wireless-testing-based wireless code up to where he could no longer
reproduce the issue.

I just verified on one of my older machines (running current fedora-11,
with a 4965AGN rev=0x4) that the problem is real, and that reverting that
commit does indeed seem to fix it.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c428c89201a57a0ce24c37ed79e540d1f4101cf3

What does "older" mean here, and what kernel were you using?

So here goes: I'm going to revert that commit today or tomorrow, unless
somebody sends me a fix that I can verify. I don't want any more excuses,
I don't want to hear developers dismissing bug-reports, and I _can_ verify
this problem myself.

We do not fix bugs by introducing new regressions and then ignoring the
reports. Especially since the bug that the commit in question fixes seems
to be _way_ less important than the bug it then introduces.

I never ignored the reports. I was a little mad at Parag because he was
reporting a bug that I had just fixed, and he had even seen the original
report. It turned out it wasn't his fault that he couldn't find the fix
from the original thread, and I suppose I could have handled the
duplicate report better even if Parag had known about the fix. I'm sorry
about that.

If you revert that commit (from subject), you're going to make it
default to transmit power -1 dBm if commit c428c892 is in your tree as
well. I have to wonder whether your testing included that commit,
because if reverting 47afbaf5 helped I would think it did not.

From my perspective the bug is dealt with since commit c428c892, if you
want to revert anything please revert _both_ c428c892 and 47afbaf5.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part



Relevant Pages

  • Re: Stop the negativism!
    ... I, for one, have seen concrete demonstration of the efforts to fix the quality issues in BDS 2006. ... none of the reports I have been interested in have ever been fixed. ... Near the top of this page they have a section "Higher Performance and Better Quality" that says "Over 500 bug reports tracked by our internal system have been fixed in this release. ... Furthermore, the user who reported the problem was still using BCB 6, and he didn't get an update or hotfix, so this issue is not resolved for him unless he pays for an update to BDS 2006 and installs update 2. ...
    (borland.public.delphi.non-technical)
  • BDS needs more bugs fixed
    ... none of the reports I have been interested in have ever been fixed. ... Near the top of this page they have a section "Higher Performance and Better Quality" that says "Over 500 bug reports tracked by our internal system have been fixed in this release. ... Furthermore, the user who reported the problem was still using BCB 6, and he didn't get an update or hotfix, so this issue is not resolved for him unless he pays for an update to BDS 2006 and installs update 2. ... it is a fix for a cosmetic issue only. ...
    (borland.public.delphi.non-technical)
  • [git pull] Please pull powerpc.git merge branch
    ... serious bugs on powerpc. ... I have included the full commit messages ... Fix build error with 64K pages and!hugetlbfs ... This bug is causing random crashes ...
    (Linux-Kernel)
  • Re: [opensuse] Why are Novell guys closing perfectly valid bugs as WONTFIX due to their laziness ?
    ... kind of "I do not want to fix it". ... from the community I have a couple of times received incredible bug ... provided enough information to fix some major bug in reduced time. ... Coincidentally, such reports are written in a nice and kind way, even if they ...
    (SuSE)
  • [git pull] Please pull powerpc.git merge branch
    ... to get three more commits that fix bugs causing kernel crashes on ... The solution in this commit is to read the current offset from ... I think this bug is triggered by having reserved areas for a node ... which is running Active Memory Sharing, we can oops the kernel. ...
    (Linux-Kernel)