Re: [PATCH] mmc_spi: do propper retry managment in the block layer - rewritten



[CC'ing Nicolas as he's the at91 mci driver maintainer]

On Tue, May 19, 2009 at 09:16:40AM +0200, Wolfgang Mües wrote:
Matt,

Am Montag, 18. Mai 2009 schrieb Matt Fleming:
Ah, now I understand. I've also been contacted privately by someone
who says that they've been experiencing similar issues and that your
patch has fixed them. Clearly there are people out there with flaky
hardware ;-)

Hmmm... Every hardware is flaky. Put a piece of hardware near your
refrigerator or DECT base, and you will have EMP or HF problems.
Or use your finger and generate ESD pulses.

I am using a piezo where I have the GND pin connected to a wire to generate
ESD pulses which have the same results as a 4 KV ESD generator:

http://www.vega-direct.at/buffet/chafing_dish_mit_zubehoer/gasanzuender/index.hsp

A software which do not behave gracefully in the presence of errors is not
production quality for me.


Oh, wow. I didn't pick up on the fact that you were artificially
generating errors on the bus. I thought you'd seen this sort of
problem in production. I don't understand what sort of fault-tolerance
you expect the MMC/SD subsystem to provide.

I've heard from one person that an earlier version of this patch fixed
issues with their at91 controller. If othe people are experiencing
similar issues and this patch fixes it for them, then it definitely
lends some weight to it.

Nicolas, do you have an opinion on the patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [RFC patch 08/18] cnt32_to_63 should use smp_rmb()
    ... Excuse me, Russell, but I sent Nicolas an email prior to doing so asking him ... but I copied Nicolas on the patch to make ... I also don't mind having a real barrier for this code to be useful on ...
    (Linux-Kernel)
  • Re: KB885250 Network Share Problems
    ... >I removed the patch and everything works as expected. ... >command by itself and no files or folders are reported. ... > Directory of Z:\2003 Resource Kit ... Only apply it to systems that are experiencing this ...
    (microsoft.public.windowsxp.network_web)
  • Re: bootsplash
    ... Nicolas Cadou wrote: ... | The stock linux VESA VGA framebuffer module is limited in its ability to ... | change the video modes of S3 Virge cards. ... | The patch makes the module behave differently with S3 Virge cards, ...
    (Debian-User)
  • BK-kernel-tools/shortlog update
    ... trailing slash) or in cases of dire need, you can apply the patch below. ... +'akpm:org.rmk.' => 'Andrew Morton', ... 'lord:jen.americas.sgi.com' => 'Stephen Lord', ... 'nicolas.mailhot:laposte.net' => 'Nicolas Mailhot', ...
    (Linux-Kernel)
  • Re: Native preemption is the culprit [was Re: todays CURRENT lockups]
    ... > The patch below appears to eliminate the crash/hang I'm ... > was experiencing it only in the SMP case, not UP, so it could be I'm just ... I have not observed anything unusual with this patch. ...
    (freebsd-current)