Re: [PATCH] TXx9: Add TX4939 RNG support



On Mon, 2009-06-01 at 02:23 +0900, Atsushi Nemoto wrote:
On Sun, 31 May 2009 12:01:29 -0500, Matt Mackall <mpm@xxxxxxxxxxx> wrote:
Not clear to me how this works when this is a module?

This patch add a registration of a platform device for RNG to vmlinux.
And the other patch add a driver module for the RNG. This strategy is
fairly common for SoCs or embedded platforms.

If your driver is built as a module (which your patch allows), the above
won't work, right?

No, the rng driver can be used regardless of module or built-in, as
like as other platform drivers. Any special issue for hw_rng?

I found the source of my confusion: you've given the init function in
both files exactly the same name. So when I saw .._init at the bottom of
the second patch, I assumed it was referring to the possibly not loaded
driver's init code.

--
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] ne.c fix for hibernate and rmmod oops fix
    ... Notable changes since the last patch: ... code doesn't even need the resources passed by the platform device. ... The ne.c driver already registers the resources it needs and there ... Note the user space ISA PnP doesn't work for suspend to disk, ...
    (Linux-Kernel)
  • Re: [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver
    ... hardware-specific header file under include/linux. ... The platform-specific code for any platform that uses that rtc will need ... I have a patch for arch/ppc/platforms/katana.c but I haven't ... If no platform data is found, the driver will attempt to ...
    (Linux-Kernel)
  • [PATCH,RFC] timer iomem hwrng driver
    ... I've noticed that the HW RNG core is orphaned so I'm posted this here... ... I have been putting together some patchesfor mainline support for the ... So I started slapping a driver together and realised it might be handy to ... that the ioremap'ing is done in the platform code. ...
    (Linux-Kernel)
  • Re: [PATCH] uio_pdrv: Unique IRQ Mode
    ... This patch adds a "Unique IRQ Mode" to the uio_pdrv UIO platform driver. ...
    (Linux-Kernel)
  • Re: [PATCH 3/7] au1xmmc: remove db1x00 board-specific functions from driver
    ... Subject: au1xmmc: remove db1x00 board-specific functions from driver ... I think you should merge the header to the driver in a separate patch. ... do you need the above structure to be visible from the platform code? ...
    (Linux-Kernel)