Re: PATCH: README - Fix misleading pointer to the defconf directory

Arnd Bergmann wrote:
On Friday 12 June 2009, Patrick Ringl wrote:
the README simply points to a wrong/non-existent directory where the default
configurations are not suited, hence the patch.

On six architectures, it's still the right directory, your patch breaks it.

Darn, I used 'find' to ensure the structure is consistent, stupidly I didn't check wether the amount of fitting cases equals the amount of platforms at all, thus I did miss those who do not fit.
Signed-off-by: Patrick Ringl <patrick_@xxxxxxxxxx>

--- linux.orig/README 2009-06-10 05:05:27.000000000 +0200
+++ linux/README 2009-06-12 10:46:15.000000000 +0200
@@ -175,7 +175,7 @@
Like above, but avoids cluttering the screen
with questions already answered.
"make defconfig" Create a ./.config file by using the default
- symbol values from arch/$ARCH/defconfig.
+ symbol values from arch/$ARCH/configs/*_defconfig.
"make allyesconfig"
Create a ./.config file by setting symbol
values to 'y' as much as possible.

You could write e.g.

default symbol values from one of arch/{$ARCH}/defconfig or
arch/${ARCH}/configs/${PLATFORM}_defconfig, depending on
the architecture.

It would also be consistent to list the specific defconfigs here, like

"make ${PLATFORM}_defconfig"
Create a ./.config file by using the default
symbol values from
arch/${ARCH}/configs/${PLATFORM}_defconfig.
Use "make help" to see a list of the available
platforms on your architecture.

I really like that approach! :-)
Not also that your patch should be merged through a subsystem maintainer.
If you don't know who that is, use scripts/get_maintainer.pl.
For scripts/kconfig/* and README it suggests sending it to Sam, Roman and
linux-kbuild@xxxxxxxxxxxxxxx, which sounds right.

Arnd <>
Right, I honestly didn't know about that useful tool (if the LKML-FAQ tells about this, I must've missed it). Thanks for your short review and the revealing of my overhasty blooper.

I am going to resend the patch with your suggestions above soon.


regards,
Patrick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH v5] RO/NX protection for loadable kernel modules
    ... It is rather distracting and annoying when code uses non-standard ... is entirely consistent with how they work at the moment: ... Half of this patch was debug statements that distracted me (and ... natural type as a parameter to avoid dangerous type-casts. ...
    (Linux-Kernel)
  • Re: morphine vs fentyl patch?
    ... > amount for amount the fentanyl is the stronger medicine, ... > the patch crapping out in 8 hours. ... or for when you experience a flare up of pain. ... >> what abt an hour for morhine kick in then it strtas faze out after abt ...
    (alt.support.chronic-pain)
  • Sat Sels
    ... furlong shouldn`t be a problem.The consistent but rarely winning IRISH WOLF ... Won with any amount in hand at Ayr beating the bottle job OONINPOHJA,and ... TRIMLESTOWN from Henry Candys honest yard is the most consistent of animals ... effect of the drawOn the other side of the draw EISTEDDFOD looks to be a ...
    (uk.sport.horseracing)
  • Re: Sat Sels
    ... furlong shouldn`t be a problem.The consistent but rarely winning IRISH ... Won with any amount in hand at Ayr beating the bottle job OONINPOHJA,and ... TRIMLESTOWN from Henry Candys honest yard is the most consistent of ... to the effect of the drawOn the other side of the draw EISTEDDFOD ...
    (uk.sport.horseracing)
  • Re: Inconsistency in Pythons Comparisons
    ... I guess I could write a patch... ... consistent results, and I expect either one or the other. ... it contained different file classes, some with paths, and some ... impossible-to-read order, the program didn't depend on the order at ...
    (comp.lang.python)
Loading