Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- From: Ben Dooks <ben-linux@xxxxxxxxx>
- Date: Tue, 16 Jun 2009 09:39:48 +0100
On Tue, Jun 16, 2009 at 09:28:48AM +0800, Alek Du wrote:
On Mon, 15 Jun 2009 21:09:06 +0800
Ben Dooks <ben-linux@xxxxxxxxx> wrote:
I would expect your architecture IRQ handler to have a set_type callback for
the GPIO lines capables of generating an interrupt. See how we have beeing
doing it for rb532 for instance:
http://www.linux-mips.org/git?p=linux-queue.git;a=blob;f=arch/mips/rb532/irq.c;h=f07882029a90d3d155c17b462812c2936229458c;hb=HEAD#l173
Yes, or if the GPIO driver is exporting interrupts, the relevant handler
for that chip should have the .set_type method defined.
In the .set_type method, you finally will call the GPIO driver's function to set interrupt trigger mode, right?
No, that's totaly the wrong way around. GPIOLIB provides an GPIO to IRQ
function that the driver providing the GPIOLIB chip needs to provide. To do
IRQs, the same driver will have to provide a irq chip and that is the place
where this functionality should reside.
Current GPIOLIB do not provide such an interface. Current driver always exports a separate function to do that --
that's not good.
My patch provide a general API to do that.
When there's already an extant API to do that. There are drivers already
doing it this way.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- From: Alek Du
- Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- From: Ben Dooks
- Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- From: Florian Fainelli
- Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- From: Ben Dooks
- Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- From: Alek Du
- [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- Prev by Date: Re: [gpm] [PATCH 2.6.29] eeepc-laptop: report brightness control events via the input layer
- Next by Date: Re: [PATCH v2 0/8] clean up vdso-layout.lds.S
- Previous by thread: Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
- Next by thread: [PATCH v2] gpiolib: Add gpio_debounce and gpio_alt_func features to GPIOLIB
- Index(es):
Relevant Pages
|
