Re: [PATCH] More i8042-reset quirks for MSI Wind-clone netbooks

On Thu, Jun 18, 2009 at 11:42:50PM +0800, Matthew Garrett wrote:
On Thu, Jun 18, 2009 at 08:08:09AM +0800, Li, Yan wrote:
That's true. But we are not sure how many regressions we'll meet and
whether the efforts devoted to handle them is worthy. (How to handle
regressions? Perhaps, ironically, we'll need another 'whitelist' for
them!)

If we hit regressions then it's the wrong fix and would have to be
reverted.

Still, I don't think we have enough reason to enable multi-reset of
i8042 for all machines: the old code (sane and following specs) has
been working well since long ago for most machines, and not until
recently we have seen special cases, no more than half a dozen
machines that needs special treating. These few glitches can't
justify a global move.

Without a good reason, your move (try and revert if hit regressions)
seems to be the trial-and-error approach, and not very good for the
stable release (though perfectly safe for some testing branches).

Better a small blacklist than a large whitelist (though, in
the general case, the presence of either is an indication of a bug)

We have no way to know which one is smaller one, the current list is
very small (5 entries). I'll change my mind if this
i8042_dmi_reset_table[] keeps growing.

The presence of {black,white}list (or more generally, quirks) is the
software reflection of the complexity of the world, not necessarily a
bug. They are popular (if not ubiquitous) among the kernel.


Does this matter? Does whether Windows fail or not affect our
decision here? (Worse that I have no "stock Windows XP" for
testing. All I have are those companion Windows Recovery CDs that
include all drivers).

Yes. If Windows works without hardware specific drivers then there's a
flaw in our i8042 setup code that's affecting an unknown number of
machines, and adding more entries to a static table tells us nothing
about what proportion of those machines are now fixed - it just tells us
that we've worked around the issue for the ones that Intel happen to be
testing.

Not necessarily if we had followed the spec (I'm not sure of this) of
using i8042.

Hope someone can help us do this test. I have already found loads of
touchpad drivers on net so I guess Windows can't drive a touchpad
until a driver is installed. Pure guess.

--
Best regards,
Li, Yan

Moblin Team, Opensource Technology Center, SSG, Intel
Office tel.: +86-10-82171695 (inet: 8-758-1695)
OpenPGP key: 5C6C31EF
IRC: yanli on network irc.freenode.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Keyboard freezing, new problem, several PCs
    ... Try reinstalling the latest drivers for your particular ... issue is related to Windows Updates. ... | Recently a number of these machines have started to exhibit "keyboard ... All these machines are strongly secured, ...
    (microsoft.public.windowsxp.general)
  • Re: Appalling Vista
    ... etc etc etc manufacturer hadn't included a drivers disk for windows ... Windoze driver. ... conflicts with other drivers, sometimes to the point of creating system instability, until the manf patches and issues an upgrade. ... I have Vista running here on a couple of machines as I am getting support calls on machines using it. ...
    (uk.legal)
  • Re: Automatically search for network folders and printers
    ... Same printers & the same drivers. ... Windows Printing Team ... Automatically install on the client machines. ...
    (microsoft.public.windowsxp.print_fax)
  • Re: Printers Folder
    ... The printers all have the correct drivers. ... I have the problem on a Windows 2000 Terminal Server ... printing to a shared printer with the same problem. ... we have XP machines that has not ...
    (microsoft.public.win2000.printing)
  • Re: Cryptogram Comment
    ... >> bother me with Windows questions. ... >> machines are broken. ... Just like if you don't know to tune up your car every year then you ... > and Linux and other open OS's make all patches FREE to redistribute. ...
    (sci.crypt)